Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: writableFinished is true before 'finish' #28811

Closed
wants to merge 1 commit into from

Conversation

@ronag
Copy link
Contributor

commented Jul 23, 2019

The current description for stream.writableFinished is not entirely correct.

Checklist
@Trott

This comment has been minimized.

Copy link
Member

commented Jul 23, 2019

Practically, I"m not sure what the difference is to the reader? Is this about what finished is set to when your finish event listener runs or something like that?

@ronag ronag force-pushed the nxtedition:fix-docs-writableFinished branch from 459e4ad to d3b065b Jul 23, 2019

@ronag

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2019

It’s important in order to know whether when I register a finish listener if it will be called or not.

@ronag ronag force-pushed the nxtedition:fix-docs-writableFinished branch from d3b065b to 2502502 Jul 23, 2019

@ronag ronag changed the title docs: writableFinished is true before 'finish' dos: writableFinished is true before 'finish' Jul 23, 2019

doc/api/http.md Outdated Show resolved Hide resolved

@ronag ronag force-pushed the nxtedition:fix-docs-writableFinished branch from 2502502 to cc13c69 Jul 23, 2019

doc/api/http.md Outdated Show resolved Hide resolved

@lpinca lpinca changed the title dos: writableFinished is true before 'finish' doc: writableFinished is true before 'finish' Jul 23, 2019

@ronag ronag force-pushed the nxtedition:fix-docs-writableFinished branch 2 times, most recently from 5998562 to 0b677a6 Jul 23, 2019

@Trott
Trott approved these changes Jul 23, 2019
@Trott

This comment has been minimized.

@Trott Trott added the author ready label Jul 25, 2019

@Trott

This comment has been minimized.

Copy link
Member

commented Jul 26, 2019

doc/api/http.md Outdated Show resolved Hide resolved

@trivikr trivikr removed the author ready label Jul 26, 2019

@ronag ronag force-pushed the nxtedition:fix-docs-writableFinished branch from 0b677a6 to c3b6f5b Aug 2, 2019

@ronag ronag force-pushed the nxtedition:fix-docs-writableFinished branch from c3b6f5b to 204b76b Aug 2, 2019

@Trott

This comment has been minimized.

doc/api/http.md Show resolved Hide resolved
@mcollina
Copy link
Member

left a comment

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Aug 2, 2019
doc: writableFinished is true before 'finish'
PR-URL: nodejs#28811
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

Landed in 0897782

@Trott Trott closed this Aug 2, 2019

targos added a commit that referenced this pull request Aug 2, 2019
doc: writableFinished is true before 'finish'
PR-URL: #28811
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@BridgeAR BridgeAR referenced this pull request Aug 6, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc: writableFinished is true before 'finish'
PR-URL: nodejs#28811
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc: writableFinished is true before 'finish'
PR-URL: nodejs#28811
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.