Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module: unify package exports test for CJS and ESM #28831

Closed
wants to merge 1 commit into from

Conversation

@jkrems
Copy link
Contributor

commented Jul 24, 2019

Refs: nodejs/modules#358

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
src/module_wrap.cc Show resolved Hide resolved

@jkrems jkrems force-pushed the jkrems:one-exports-test branch from 5db4226 to 5d8e3fb Jul 24, 2019

@jkrems jkrems changed the title module: unify test suite for CJS and ESM module: unify package exports test for CJS and ESM Jul 24, 2019

@jkrems jkrems force-pushed the jkrems:one-exports-test branch from 5d8e3fb to 84ccea8 Jul 24, 2019

@guybedford
Copy link
Contributor

left a comment

Great to have unified tests indeed.

src/module_wrap.cc Show resolved Hide resolved
src/module_wrap.cc Outdated Show resolved Hide resolved
test/common/index.mjs Show resolved Hide resolved

@jkrems jkrems force-pushed the jkrems:one-exports-test branch from 84ccea8 to aab065b Jul 24, 2019

@jkrems

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2019

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment has been minimized.

Copy link

commented Jul 26, 2019

@Trott

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

This could use more reviews. @nodejs/collaborators

@guybedford

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

More approvals would be great, but this should still be good to merge given the 7 days now I believe.

@Trott
Trott approved these changes Jul 31, 2019
@Trott
Copy link
Member

left a comment

abort/test-addon-uv-handle-leak is failing locally for me with this change. Will re-run CI while I investigate locally.... Could be something incompatible slipped in while this PR was baking....

@nodejs-github-bot

This comment has been minimized.

@Trott
Trott approved these changes Jul 31, 2019
@Trott

This comment has been minimized.

Copy link
Member

commented Jul 31, 2019

Looks like I just needed to do a more thorough rebuild to catch up my addons. I think this is good although out of caution, I'll wait for the CI re-run results.

@nodejs-github-bot

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Jul 31, 2019

Landed in 61f3a5c

@Trott Trott closed this Jul 31, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jul 31, 2019
module: unify package exports test for CJS and ESM
Refs: nodejs/modules#358

PR-URL: nodejs#28831
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Aug 2, 2019
module: unify package exports test for CJS and ESM
Refs: nodejs/modules#358

PR-URL: #28831
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@jkrems jkrems added this to In progress in Support "exports" in package.json via automation Aug 6, 2019

@jkrems jkrems moved this from In progress to Done in Support "exports" in package.json Aug 6, 2019

@BridgeAR BridgeAR referenced this pull request Aug 6, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
module: unify package exports test for CJS and ESM
Refs: nodejs/modules#358

PR-URL: nodejs#28831
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
module: unify package exports test for CJS and ESM
Refs: nodejs/modules#358

PR-URL: nodejs#28831
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.