Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade npm to 6.10.2 #28853

Closed
wants to merge 1 commit into from

Conversation

@isaacs
Copy link
Contributor

commented Jul 25, 2019

v6.10.2 (2019-07-23):

tl;dr - Fixes several issues with the cache when npm is run as sudo on Unix systems.

TESTING

BUGFIXES

DEPENDENCIES

@Trott
Trott approved these changes Jul 25, 2019
Copy link
Member

left a comment

Rubber-stamp LGTM

@nodejs-github-bot

This comment has been minimized.

@trivikr
Copy link
Member

left a comment

RSLGTM

@Trott

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

6.10.2 was released 9 days ago, and our policy is that it can land in master after 14 days, so this can land on or around August 5.

@Trott Trott force-pushed the npm:npm-6.10.2 branch from bee0681 to 109effd Aug 1, 2019

@Trott

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

Rebased to eliminate conflict (deleted backup file deps/npm/node_modules/copy-concurrently/README.md~, but that's it) and force pushed.

@nodejs-github-bot

This comment has been minimized.

@ZYSzys
ZYSzys approved these changes Aug 1, 2019
Copy link
Member

left a comment

RSLGTM

@irega

This comment has been minimized.

Copy link

commented Aug 6, 2019

waiting impatiently for the merge! 🎉 🎉 🎉

@targos

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

Landed in d7d321b

@targos targos closed this Aug 6, 2019

targos added a commit that referenced this pull request Aug 6, 2019
deps: upgrade npm to 6.10.2
PR-URL: #28853
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
BridgeAR added a commit that referenced this pull request Aug 6, 2019
deps: upgrade npm to 6.10.2
PR-URL: #28853
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@BridgeAR BridgeAR referenced this pull request Aug 6, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
deps: upgrade npm to 6.10.2
PR-URL: nodejs#28853
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
deps: upgrade npm to 6.10.2
PR-URL: nodejs#28853
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.