Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct import statement #28876

Closed
wants to merge 2 commits into from

Conversation

@Himself65
Copy link
Contributor

commented Jul 27, 2019

fix #28861

JSON file can be imported now

// index.mjs
import pkg from  '../package.json'
console.log(pkg)
Checklist

@Himself65 Himself65 force-pushed the Himself65:28861 branch from 5d835df to e3f49d0 Jul 27, 2019

@lpinca
lpinca approved these changes Jul 27, 2019
@Trott

This comment has been minimized.

Copy link
Member

commented Jul 27, 2019

Should JSON be added to the previous line listing allowable things to import?

@Himself65 Himself65 force-pushed the Himself65:28861 branch from e3f49d0 to d8ffcb4 Jul 28, 2019

@Himself65

This comment has been minimized.

Copy link
Contributor Author

commented Jul 28, 2019

@Trott added

doc: correct import statement
JSON file can be imported now

@Himself65 Himself65 force-pushed the Himself65:28861 branch from d8ffcb4 to 849ca9d Jul 28, 2019

@trivikr trivikr requested a review from Trott Jul 29, 2019

@Trott

This comment has been minimized.

@Trott
Trott approved these changes Jul 29, 2019
@cjihrig

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2019

Still LGTM

@Trott

This comment has been minimized.

Copy link
Member

commented Jul 29, 2019

Landed in 8a10b50

@Trott Trott closed this Jul 29, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jul 29, 2019
doc: correct import statement
JSON file can be imported now

PR-URL: nodejs#28876
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Aug 2, 2019
doc: correct import statement
JSON file can be imported now

PR-URL: #28876
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR referenced this pull request Aug 6, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc: correct import statement
JSON file can be imported now

PR-URL: nodejs#28876
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc: correct import statement
JSON file can be imported now

PR-URL: nodejs#28876
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.