Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test, util: refactor isObject in test-util #28878

Closed
wants to merge 1 commit into from

Conversation

@RamirezAlex
Copy link
Member

commented Jul 27, 2019

Refactor the test for isObject function including falsy values,
the use of strictEquals and the format actual, expected

  • make -j4 test (UNIX)
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
test, util: refactor isObject in test-util
refactor the test for isObject function including falsy values,
the use of strictEquals and the format actual, expected
@targos
targos approved these changes Jul 27, 2019

@hiroppy hiroppy added the util label Jul 27, 2019

@ZYSzys
ZYSzys approved these changes Jul 28, 2019
@nodejs-github-bot

This comment has been minimized.

@ZYSzys ZYSzys added the author ready label Jul 28, 2019

@Trott
Trott approved these changes Jul 28, 2019
@Trott

This comment has been minimized.

Copy link
Member

commented Jul 29, 2019

Landed in 2713f78

@Trott Trott closed this Jul 29, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jul 29, 2019
test, util: refactor isObject in test-util
refactor the test for isObject function including falsy values,
the use of strictEquals and the format actual, expected

PR-URL: nodejs#28878
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Aug 2, 2019
test, util: refactor isObject in test-util
refactor the test for isObject function including falsy values,
the use of strictEquals and the format actual, expected

PR-URL: #28878
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR referenced this pull request Aug 6, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
test, util: refactor isObject in test-util
refactor the test for isObject function including falsy values,
the use of strictEquals and the format actual, expected

PR-URL: nodejs#28878
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
test, util: refactor isObject in test-util
refactor the test for isObject function including falsy values,
the use of strictEquals and the format actual, expected

PR-URL: nodejs#28878
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.