Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix nits in test/fixtures/tls-connect.js #28880

Closed
wants to merge 1 commit into from

Conversation

@lpinca
Copy link
Member

commented Jul 28, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@lpinca lpinca force-pushed the lpinca:fix/nits branch from 07c216f to 66a251f Jul 28, 2019

@lpinca lpinca force-pushed the lpinca:fix/nits branch from 66a251f to 9f5d133 Jul 28, 2019

@@ -92,7 +92,7 @@ exports.connect = function connect(options, callback) {
function maybeCallback() {
if (!callback)
return;
if (server.conn && (client.conn || client.err)) {

This comment has been minimized.

Copy link
@lpinca

lpinca Jul 28, 2019

Author Member

client.err is set by the 'error' listener of the client socket or in the catch branch of the try...catch around tls.connect(). In the latter case maybeCallback() is not used as the callback is called directly. In the former client.conn is also set.

@Trott
Trott approved these changes Jul 30, 2019

@Trott Trott added the author ready label Jul 30, 2019

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

Landed in 834a413

@Trott Trott closed this Jul 30, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jul 30, 2019
test: fix nits in test/fixtures/tls-connect.js
PR-URL: nodejs#28880
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@lpinca lpinca deleted the lpinca:fix/nits branch Jul 31, 2019

targos added a commit that referenced this pull request Aug 2, 2019
test: fix nits in test/fixtures/tls-connect.js
PR-URL: #28880
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR referenced this pull request Aug 6, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
test: fix nits in test/fixtures/tls-connect.js
PR-URL: nodejs#28880
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
test: fix nits in test/fixtures/tls-connect.js
PR-URL: nodejs#28880
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.