Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fixup esm resolver spec formatting #28885

Closed
wants to merge 1 commit into from

Conversation

@guybedford
Copy link
Contributor

commented Jul 28, 2019

This fixes up the formatting of the esm resolver spec in the docs, which is currently showing some markdown issues - https://nodejs.org/dist/latest-v12.x/docs/api/esm.html#esm_resolution_algorithm.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@targos
targos approved these changes Jul 29, 2019
@targos

This comment has been minimized.

Copy link
Member

commented Jul 29, 2019

👍 to fast-track

@lpinca
lpinca approved these changes Jul 29, 2019
@nodejs-github-bot

This comment has been minimized.

@guybedford

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2019

Landed in 816db9e.

@guybedford guybedford closed this Jul 30, 2019

@guybedford guybedford deleted the guybedford-patch-1 branch Jul 30, 2019

guybedford added a commit that referenced this pull request Jul 30, 2019
doc: fixup esm resolver spec formatting
PR-URL: #28885
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos added a commit that referenced this pull request Aug 2, 2019
doc: fixup esm resolver spec formatting
PR-URL: #28885
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR referenced this pull request Aug 6, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc: fixup esm resolver spec formatting
PR-URL: nodejs#28885
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc: fixup esm resolver spec formatting
PR-URL: nodejs#28885
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.