Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: revoke DEP0089 #28892

Merged
merged 1 commit into from Jul 31, 2019

Conversation

@cjihrig
Copy link
Contributor

commented Jul 29, 2019

Using the legacy assert module is not discouraged. Revoke DEP0089 to avoid user confusion.

Fixes: #28780

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@lpinca

lpinca approved these changes Jul 29, 2019

doc/api/deprecations.md Outdated Show resolved Hide resolved

@cjihrig cjihrig force-pushed the cjihrig:depr branch from cbe0508 to b9f2b3a Jul 29, 2019

@Trott

Trott approved these changes Jul 30, 2019

@Trott

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

doc: revoke DEP0089
Using the legacy assert module is not discouraged. Revoke
DEP0089 to avoid user confusion.

PR-URL: #28892
Fixes: #28780
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

@cjihrig cjihrig force-pushed the cjihrig:depr branch from b9f2b3a to 2abdfc5 Jul 31, 2019

@cjihrig

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2019

@cjihrig cjihrig merged commit 2abdfc5 into nodejs:master Jul 31, 2019

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details

@cjihrig cjihrig deleted the cjihrig:depr branch Jul 31, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jul 31, 2019

@Trott Trott referenced this pull request Jul 31, 2019
3 of 3 tasks complete

Trott added a commit to Trott/io.js that referenced this pull request Aug 2, 2019

doc: remove legacy mode deprecation in assert
The deprecation was revoked in
nodejs#28892.

PR-URL: nodejs#28909
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos added a commit that referenced this pull request Aug 2, 2019

doc: revoke DEP0089
Using the legacy assert module is not discouraged. Revoke
DEP0089 to avoid user confusion.

PR-URL: #28892
Fixes: #28780
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

targos added a commit that referenced this pull request Aug 2, 2019

doc: remove legacy mode deprecation in assert
The deprecation was revoked in
#28892.

PR-URL: #28909
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

Belated 👍

I have never been really happy with this.

@BridgeAR BridgeAR referenced this pull request Aug 6, 2019

BridgeAR added a commit that referenced this pull request Aug 6, 2019

2019-08-06, Version 12.8.0 (Current)
Notable changes:

* assert:
  * Legacy mode deprecation (`DEP0089`) is revoked (Colin Ihrig)
    #28892
* crypto:
  * The `outputLength` option is added to `crypto.createHash`
    (Tobias Nießen) #28805
  * The `maxmem` range is increased from 32 to 53 bits (Tobias Nießen)
    #28799
* n-api:
  * Added APIs for per-instance state management (Gabriel Schulhof)
    #28682
* report:
  * Network interfaces get included in the report (cjihrig)
    #28911
* src:
  * `v8.getHeapCodeStatistics()` is now exported
    (Yuriy Vasiyarov) #27978

PR-URL: #29017

BridgeAR added a commit to BridgeAR/node that referenced this pull request Aug 6, 2019

2019-08-06, Version 12.8.0 (Current)
Notable changes:

* assert:
  * Legacy mode deprecation (`DEP0089`) is revoked (Colin Ihrig)
    nodejs#28892
* crypto:
  * The `outputLength` option is added to `crypto.createHash`
    (Tobias Nießen) nodejs#28805
  * The `maxmem` range is increased from 32 to 53 bits (Tobias Nießen)
    nodejs#28799
* n-api:
  * Added APIs for per-instance state management (Gabriel Schulhof)
    nodejs#28682
* report:
  * Network interfaces get included in the report (cjihrig)
    nodejs#28911
* src:
  * `v8.getHeapCodeStatistics()` is now exported
    (Yuriy Vasiyarov) nodejs#27978

PR-URL: nodejs#29017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.