Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n-api: refactoring napi_create_function testing #28894

Conversation

@octaviansoldea
Copy link
Contributor

commented Jul 29, 2019

PR-URL: #26998

This is a refactoring of #26998
following #28505.

The functions add_last_status() and add_returned_status() are now
reused, see also #28848.

PR-URL: #26998
PR-URL: #28505
PR-URL: #28848

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
n-api: refactoring napi_create_function testing
PR-URL: #26998

This is a refactoring of #26998
following #28505.

The functions `add_last_status()` and `add_returned_status()` are now
reused, see also #28848.

PR-URL: #26998
PR-URL: #28505
PR-URL: #28848
@mhdawson
Copy link
Member

left a comment

LGTM

@nodejs-github-bot

This comment has been minimized.

@Trott
Trott approved these changes Aug 1, 2019
@Trott

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

Landed in 1ee47d5

@Trott Trott closed this Aug 1, 2019

Trott added a commit to Trott/io.js that referenced this pull request Aug 1, 2019
n-api: refactoring napi_create_function testing
This is a refactoring of nodejs#26998
following nodejs#28505.

The functions `add_last_status()` and `add_returned_status()` are now
reused, see also nodejs#28848.

PR-URL: nodejs#28894
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Aug 2, 2019
n-api: refactoring napi_create_function testing
This is a refactoring of #26998
following #28505.

The functions `add_last_status()` and `add_returned_status()` are now
reused, see also #28848.

PR-URL: #28894
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR referenced this pull request Aug 6, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
n-api: refactoring napi_create_function testing
This is a refactoring of nodejs#26998
following nodejs#28505.

The functions `add_last_status()` and `add_returned_status()` are now
reused, see also nodejs#28848.

PR-URL: nodejs#28894
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
n-api: refactoring napi_create_function testing
This is a refactoring of nodejs#26998
following nodejs#28505.

The functions `add_last_status()` and `add_returned_status()` are now
reused, see also nodejs#28848.

PR-URL: nodejs#28894
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.