Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include stubs in shared library #28897

Closed
wants to merge 1 commit into from

Conversation

@jeroen
Copy link
Contributor

commented Jul 29, 2019

This is needed for external applications to link to shared libnode. Fixes #27431

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@refack does this seem OK?

build: include stubs in shared library
This is needed for external applications that link to shared libnode.
Fixes #27431

@jeroen jeroen force-pushed the jeroen:sharedfix branch from 53cec3d to 0923f58 Jul 29, 2019

@jeroen jeroen marked this pull request as ready for review Jul 29, 2019

@Trott

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

@nodejs-github-bot

This comment has been minimized.

@Trott Trott requested a review from refack Aug 1, 2019

@bnoordhuis
Copy link
Member

left a comment

Thanks, LGTM.

@Trott
Trott approved these changes Aug 1, 2019
Copy link
Member

left a comment

LGTM. I'm not a gyp expert, but CI is green, got another approval from a domain expert, and this would be easy to revert if it came to it. So 👍 .

@Trott

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

Landed in ed138ba

@Trott Trott closed this Aug 1, 2019

Trott added a commit to Trott/io.js that referenced this pull request Aug 1, 2019
build: include stubs in shared library
This is needed for external applications that link to shared libnode.
Fixes nodejs#27431

PR-URL: nodejs#28897
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Aug 2, 2019
build: include stubs in shared library
This is needed for external applications that link to shared libnode.
Fixes #27431

PR-URL: #28897
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR referenced this pull request Aug 6, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
build: include stubs in shared library
This is needed for external applications that link to shared libnode.
Fixes nodejs#27431

PR-URL: nodejs#28897
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
build: include stubs in shared library
This is needed for external applications that link to shared libnode.
Fixes nodejs#27431

PR-URL: nodejs#28897
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.