Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Include "exports" resolver specification #28899

Closed
wants to merge 5 commits into from

Conversation

@guybedford
Copy link
Contributor

commented Jul 30, 2019

This amends the ES module resolver specification in the documentation to include the behaviour of the "exports" feature as implemented and merged in #28568.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@guybedford guybedford requested a review from jkrems Jul 30, 2019

@jkrems
Copy link
Contributor

left a comment

One nit about the non-object edge case. Other LGTM.

doc/api/esm.md Outdated Show resolved Hide resolved
doc/api/esm.md Outdated Show resolved Hide resolved
doc/api/esm.md Outdated Show resolved Hide resolved
@guybedford

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2019

@jkrems I believe I've adjusted it to the implementation now, thanks.

@guybedford guybedford force-pushed the guybedford:exports-spec branch from d2c9b2d to cfe78ce Jul 30, 2019

@jkrems
jkrems approved these changes Jul 30, 2019
@guybedford guybedford referenced this pull request Jul 31, 2019
@Trott
Trott approved these changes Aug 1, 2019
@Trott

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3817/ (scheduled--Jenkins is going down but presumably the CI job will kick off when it's back up)

@Trott Trott added the author ready label Aug 1, 2019

Trott added a commit to Trott/io.js that referenced this pull request Aug 1, 2019
doc: include "exports" resolver specification
PR-URL: nodejs#28899
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

Landed in 8492acf

@Trott Trott closed this Aug 1, 2019

targos added a commit that referenced this pull request Aug 2, 2019
doc: include "exports" resolver specification
PR-URL: #28899
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR referenced this pull request Aug 6, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc: include "exports" resolver specification
PR-URL: nodejs#28899
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc: include "exports" resolver specification
PR-URL: nodejs#28899
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.