Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor test-beforeexit-event-exit using mustNotCall #28901

Closed

Conversation

@Himself65
Copy link
Contributor

commented Jul 30, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@lpinca
lpinca approved these changes Jul 30, 2019
@Trott
Copy link
Member

left a comment

LGTM once the unused require('assert') is removed.

@Himself65 Himself65 force-pushed the Himself65:test-beforeexit-event-exit branch from 048f95b to 8ba62c7 Jul 31, 2019

@ZYSzys
ZYSzys approved these changes Jul 31, 2019
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@Trott
Trott approved these changes Jul 31, 2019

@Trott Trott added the author ready label Jul 31, 2019

@jasnell
jasnell approved these changes Aug 1, 2019
@Trott

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

Landed in 980df1c

@Trott Trott closed this Aug 1, 2019

Trott added a commit to Trott/io.js that referenced this pull request Aug 1, 2019
test: refactor test-beforeexit-event-exit using mustNotCall
PR-URL: nodejs#28901
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Aug 2, 2019
test: refactor test-beforeexit-event-exit using mustNotCall
PR-URL: #28901
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR referenced this pull request Aug 6, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
test: refactor test-beforeexit-event-exit using mustNotCall
PR-URL: nodejs#28901
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
test: refactor test-beforeexit-event-exit using mustNotCall
PR-URL: nodejs#28901
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.