Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix race in test-http2-origin #28903

Closed
wants to merge 1 commit into from

Conversation

@jmendeth
Copy link
Contributor

commented Jul 30, 2019

#27861 has uncovered another race in test-http2-origin. If origin fires too soon, the session will be closed while the request is in progress:

Error [ERR_HTTP2_STREAM_ERROR]: Stream closed with error code NGHTTP2_REFUSED_STREAM
    at ClientHttp2Stream._destroy (internal/http2/core.js:1974:13)
    at ClientHttp2Stream.destroy (internal/streams/destroy.js:37:8)
    at ClientHttp2Stream.[kMaybeDestroy] (internal/http2/core.js:1990:12)
    at Http2Stream.onStreamClose (internal/http2/core.js:391:26)
Emitted 'error' event at:
    at emitErrorNT (internal/streams/destroy.js:91:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
    at processTicksAndRejections (internal/process/task_queues.js:77:11)
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@jmendeth

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2019

@addaleax This is blocking the backport for #27861, should I just include these changes in the backport and submit it now? Or should I wait until this lands and cherry-pick it in the backport?

@addaleax addaleax added the http2 label Jul 30, 2019

@addaleax
Copy link
Member

left a comment

@jmendeth Thank you for taking this on! Since this is a test change, I think what I would suggest would be to land this as soon as possible, and then afterwards you can include it as a cherry-pick in the backport PR – that works, right?

@nodejs-github-bot

This comment has been minimized.

@addaleax

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

Collaborators, feel free to 👍 this comment to approve fast-tracking.

@jmendeth

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2019

Great, thanks!!

@Trott
Trott approved these changes Jul 30, 2019
@Trott

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

Landed in 985c5f5

@Trott Trott closed this Jul 30, 2019

Trott added a commit to Trott/io.js that referenced this pull request Jul 30, 2019
test: fix race in test-http2-origin
PR-URL: nodejs#28903
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
jmendeth added a commit to jmendeth/node that referenced this pull request Jul 30, 2019
test: fix race in test-http2-origin
PR-URL: nodejs#28903
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@jmendeth jmendeth deleted the jmendeth:patch-1 branch Jul 30, 2019

targos added a commit that referenced this pull request Aug 2, 2019
test: fix race in test-http2-origin
PR-URL: #28903
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR referenced this pull request Aug 6, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
test: fix race in test-http2-origin
PR-URL: nodejs#28903
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
test: fix race in test-http2-origin
PR-URL: nodejs#28903
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.