Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: destroy when call settingsFn throw an error #28908

Closed
wants to merge 2 commits into from

Conversation

@Himself65
Copy link
Contributor

commented Jul 31, 2019

fix #28895

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@lpinca
lpinca approved these changes Jul 31, 2019
test/parallel/test-http2-connect.js Outdated Show resolved Hide resolved

@Himself65 Himself65 force-pushed the Himself65:28895 branch 6 times, most recently from 52cde56 to f8371b2 Aug 1, 2019

@Himself65 Himself65 force-pushed the Himself65:28895 branch from f8371b2 to 43454d4 Aug 1, 2019

@Himself65

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

done

@trivikr
trivikr approved these changes Aug 1, 2019
@jasnell
jasnell approved these changes Aug 1, 2019
@nodejs-github-bot

This comment has been minimized.

@Trott
Trott approved these changes Aug 2, 2019

@Trott Trott added the author ready label Aug 2, 2019

@Trott

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

Landed in 2b03e1d

@Trott Trott closed this Aug 2, 2019

Trott added a commit to Trott/io.js that referenced this pull request Aug 2, 2019
http2: destroy when settingsFn throws an error
http2.connect should call destroy when init fails.

PR-URL: nodejs#28908
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Aug 2, 2019
http2: destroy when settingsFn throws an error
http2.connect should call destroy when init fails.

PR-URL: #28908
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@Himself65 Himself65 deleted the Himself65:28895 branch Aug 5, 2019

@BridgeAR BridgeAR referenced this pull request Aug 6, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
http2: destroy when settingsFn throws an error
http2.connect should call destroy when init fails.

PR-URL: nodejs#28908
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
http2: destroy when settingsFn throws an error
http2.connect should call destroy when init fails.

PR-URL: nodejs#28908
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.