Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove legacy mode deprecation in assert #28909

Merged
merged 0 commits into from Aug 2, 2019

Conversation

@Trott
Copy link
Member

commented Jul 31, 2019

The deprecation was revoked in
#28892.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@Trott Trott requested a review from cjihrig Jul 31, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Jul 31, 2019

@Trott Trott added the author ready label Jul 31, 2019

@lpinca
lpinca approved these changes Jul 31, 2019
@jasnell
jasnell approved these changes Aug 1, 2019

@Trott Trott closed this Aug 2, 2019

@Trott Trott force-pushed the Trott:remove-from-docs branch from d024b23 to 36864a6 Aug 2, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

Landed in 36864a6

@Trott Trott deleted the Trott:remove-from-docs branch Aug 2, 2019

@Trott Trott merged commit 36864a6 into nodejs:master Aug 2, 2019

1 check failed

Travis CI - Branch Build Canceled
Details
targos added a commit that referenced this pull request Aug 2, 2019
doc: remove legacy mode deprecation in assert
The deprecation was revoked in
#28892.

PR-URL: #28909
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR referenced this pull request Aug 6, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc: remove legacy mode deprecation in assert
The deprecation was revoked in
nodejs#28892.

PR-URL: nodejs#28909
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc: remove legacy mode deprecation in assert
The deprecation was revoked in
nodejs#28892.

PR-URL: nodejs#28909
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.