Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report: include network interfaces in report #28911

Merged
merged 1 commit into from Aug 3, 2019

Conversation

@cjihrig
Copy link
Contributor

commented Jul 31, 2019

To assist in debugging networking issues.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@ZYSzys

ZYSzys approved these changes Aug 1, 2019

@nodejs-github-bot

This comment has been minimized.

@jasnell

jasnell approved these changes Aug 1, 2019

@nodejs-github-bot

This comment has been minimized.

@Trott Trott added the semver-minor label Aug 2, 2019

@Trott

Trott approved these changes Aug 2, 2019

@Trott Trott added the author ready label Aug 2, 2019

report: include network interfaces in report
PR-URL: #28911
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@cjihrig cjihrig force-pushed the cjihrig:ifs branch from 172f441 to 1592d0a Aug 3, 2019

@cjihrig cjihrig merged commit 1592d0a into nodejs:master Aug 3, 2019

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details

@cjihrig cjihrig deleted the cjihrig:ifs branch Aug 3, 2019

BridgeAR added a commit that referenced this pull request Aug 6, 2019

report: include network interfaces in report
PR-URL: #28911
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

BridgeAR added a commit that referenced this pull request Aug 6, 2019

2019-08-06, Version 12.8.0 (Current)
Notable changes:

* crypto:
  * The `outputLength` option is added to `crypto.createHash`
    (Tobias Nießen) #28805
  * The `maxmem` range is increased from 32 to 53 bits (Tobias Nießen)
    #28799
* n-api:
  * Added APIs for per-instance state management (Gabriel Schulhof)
    #28682
* report:
  * Network interfaces get included in the report (cjihrig)
    #28911
* src:
  * `v8.GetHeapCodeAndMetadataStatistics()` is now exported
    (Yuriy Vasiyarov) #27978

PR-URL: #TBD
@BridgeAR BridgeAR referenced this pull request Aug 6, 2019

BridgeAR added a commit that referenced this pull request Aug 6, 2019

2019-08-06, Version 12.8.0 (Current)
Notable changes:

* crypto:
  * The `outputLength` option is added to `crypto.createHash`
    (Tobias Nießen) #28805
  * The `maxmem` range is increased from 32 to 53 bits (Tobias Nießen)
    #28799
* n-api:
  * Added APIs for per-instance state management (Gabriel Schulhof)
    #28682
* report:
  * Network interfaces get included in the report (cjihrig)
    #28911
* src:
  * `v8.GetHeapCodeAndMetadataStatistics()` is now exported
    (Yuriy Vasiyarov) #27978

PR-URL: #29017

BridgeAR added a commit that referenced this pull request Aug 6, 2019

2019-08-06, Version 12.8.0 (Current)
Notable changes:

* assert:
  * Legacy mode deprecation (`DEP0089`) is revoked (Colin Ihrig)
    #28892
* crypto:
  * The `outputLength` option is added to `crypto.createHash`
    (Tobias Nießen) #28805
  * The `maxmem` range is increased from 32 to 53 bits (Tobias Nießen)
    #28799
* n-api:
  * Added APIs for per-instance state management (Gabriel Schulhof)
    #28682
* report:
  * Network interfaces get included in the report (cjihrig)
    #28911
* src:
  * `v8.getHeapCodeStatistics()` is now exported
    (Yuriy Vasiyarov) #27978

PR-URL: #29017

BridgeAR added a commit to BridgeAR/node that referenced this pull request Aug 6, 2019

2019-08-06, Version 12.8.0 (Current)
Notable changes:

* assert:
  * Legacy mode deprecation (`DEP0089`) is revoked (Colin Ihrig)
    nodejs#28892
* crypto:
  * The `outputLength` option is added to `crypto.createHash`
    (Tobias Nießen) nodejs#28805
  * The `maxmem` range is increased from 32 to 53 bits (Tobias Nießen)
    nodejs#28799
* n-api:
  * Added APIs for per-instance state management (Gabriel Schulhof)
    nodejs#28682
* report:
  * Network interfaces get included in the report (cjihrig)
    nodejs#28911
* src:
  * `v8.getHeapCodeStatistics()` is now exported
    (Yuriy Vasiyarov) nodejs#27978

PR-URL: nodejs#29017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.