Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update V8 to 7.7 #28918

Merged
merged 18 commits into from Aug 19, 2019

Conversation

@targos
Copy link
Member

commented Aug 1, 2019

ETA: Sept 10th, 2019

@targos

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2019

There are a few postmortem-related issues:

15:35:12 dtrace: failed to compile script src/v8ustack.d: line 414: failed to resolve V8DBG_CLASS_CONSSTRING__FIRST__STRING: Unknown variable name
15:55:33 not ok 1 v8-updates/test-postmortem-metadata
15:55:33   ---
15:55:33   duration_ms: 0.262
15:55:33   severity: fail
15:55:33   exitcode: 1
15:55:33   stack: |-
15:55:33     assert.js:89
15:55:33       throw new AssertionError(obj);
15:55:33       ^
15:55:33     
15:55:33     AssertionError [ERR_ASSERTION]: Missing constants: v8dbg_class_ConsString__first__String,v8dbg_class_ConsString__second__String,v8dbg_class_SlicedString__offset__SMI,v8dbg_class_ThinString__actual__String

/cc @nodejs/platform-smartos

@targos

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2019

V8 CI failed on all IBM platforms with this error:

15:27:46 ERROR at //BUILD.gn:1032:14: Unknown function.
15:27:46     filetq = string_replace(file, ".tq", "-tq-csa")
15:27:46              ^-------------

Maybe GN needs an update?

Example: https://ci.nodejs.org/job/node-test-commit-v8-linux/2440/nodes=centos7-ppcle,v8test=v8test/console

@cjihrig

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

@targos I'll fix those up here and update the existing V8 CR (trying to avoid working with Gerrit as much as possible).

@targos

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

@miladfarca

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

@targos gn needs to be updated, latest gn runs fine on ppc and the above remote ref, tested on ubuntu1404-ppc64_le-2

@targos

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

@miladfarca Thanks, I opened nodejs/build#1881 to ask the build WG to update gn.

@cjihrig

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

@targos please cherry-pick cjihrig@d9326fa, cjihrig@c9c0757, and cjihrig@46ac4d3 to fix the postmortem and SmartOS failures.

@targos

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

@cjihrig Thanks, I included your commits.

@targos targos force-pushed the targos:v8-7.7 branch from 56c4f8e to 45837a1 Aug 13, 2019
@nodejs-github-bot

This comment has been minimized.

@devsnek

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

@targos targos force-pushed the targos:v8-7.7 branch from 45837a1 to 28db63b Aug 16, 2019
@nodejs-github-bot

This comment has been minimized.

@targos

This comment has been minimized.

Copy link
Member Author

commented Aug 16, 2019

/cc @nodejs/v8-update @nodejs/tsc

I'd like to land this early. If we do that, it gives us time to try and include it in v12.x.
V8 7.7 was already branched upstream and should only get bugfixes until its stable release.

Copy link
Member

left a comment

LGTM, nice job!

We've accreted quite a few patches on top of V8 lately. Are there plans to upstream them?

I suppose in some cases we'll have to carry them forward because the V8 team probably isn't interested in supporting older compilers.

common.gypi Outdated
@@ -39,7 +39,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.6',
'v8_embedder_string': '-node.7',

This comment has been minimized.

Copy link
@bnoordhuis

bnoordhuis Aug 16, 2019

Member

There's a typo in the commit log (s/in all platforms/on all platforms/) and I don't see that -Wbraced-scalar-init it mentions anywhere.

This comment has been minimized.

Copy link
@targos

targos Aug 16, 2019

Author Member

Thanks, I'll fix that

@targos targos removed the blocked label Aug 16, 2019
@targos

This comment has been minimized.

Copy link
Member Author

commented Aug 16, 2019

We've accreted quite a few patches on top of V8 lately. Are there plans to upstream them?

I can try to upstream some of the changes but I don't understand all of them enough to explain the V8 team why they are necessary.

@Trott

This comment has been minimized.

Copy link
Member

commented Aug 17, 2019

/cc @nodejs/v8-update @nodejs/tsc

I'd like to land this early. If we do that, it gives us time to try and include it in v12.x.
V8 7.7 was already branched upstream and should only get bugfixes until its stable release.

I'm +1 to "land this when @targos thinks it should be landed".

@Trott
Trott approved these changes Aug 17, 2019
Copy link
Member

left a comment

Rubber stamp LGTM

JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
The following metadata has changed:

- v8dbg_class_ConsString__first__String
  - Class is now generated via torque.
  - Postmortem tools should use v8dbg_class_ConsString__first_offset__int
  - Refs: v8/v8@14274bb

- v8dbg_class_ConsString__second__String
  - Class is now generated via torque.
  - Postmortem tools should use v8dbg_class_ConsString__second_offset__int
  - Refs: v8/v8@14274bb

- v8dbg_class_SlicedString__offset__SMI
  - Class is now generated via torque.
  - Postmortem tools should use v8dbg_class_SlicedString__offset_offset__int
  - Refs: v8/v8@14274bb

- v8dbg_class_ThinString__actual__String
  - Class is now generated via torque.
  - Postmortem tools should use v8dbg_class_ThinString__actual_offset__int
  - Refs: v8/v8@14274bb

PR-URL: nodejs#28918
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
PR-URL: nodejs#28918
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit to targos/node that referenced this pull request Sep 17, 2019
Update postmortem metadata constants for V8 7.7 in Node.js.

PR-URL: nodejs#28918
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit to targos/node that referenced this pull request Sep 17, 2019
Co-authored-by: Ujjwal Sharma <usharma1998@gmail.com>

PR-URL: nodejs#28918
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit to targos/node that referenced this pull request Sep 17, 2019
PR-URL: nodejs#28918
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit to targos/node that referenced this pull request Sep 17, 2019
The following metadata has changed:

- v8dbg_class_ConsString__first__String
  - Class is now generated via torque.
  - Postmortem tools should use v8dbg_class_ConsString__first_offset__int
  - Refs: v8/v8@14274bb

- v8dbg_class_ConsString__second__String
  - Class is now generated via torque.
  - Postmortem tools should use v8dbg_class_ConsString__second_offset__int
  - Refs: v8/v8@14274bb

- v8dbg_class_SlicedString__offset__SMI
  - Class is now generated via torque.
  - Postmortem tools should use v8dbg_class_SlicedString__offset_offset__int
  - Refs: v8/v8@14274bb

- v8dbg_class_ThinString__actual__String
  - Class is now generated via torque.
  - Postmortem tools should use v8dbg_class_ThinString__actual_offset__int
  - Refs: v8/v8@14274bb

PR-URL: nodejs#28918
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit to targos/node that referenced this pull request Sep 17, 2019
PR-URL: nodejs#28918
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Sep 19, 2019
Backport-PR-URL: #29241
PR-URL: #28918
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Sep 19, 2019
Backport-PR-URL: #29241
PR-URL: #28918
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Sep 19, 2019
Update postmortem metadata constants for V8 7.7 in Node.js.

Backport-PR-URL: #29241
PR-URL: #28918
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Sep 19, 2019
Co-authored-by: Ujjwal Sharma <usharma1998@gmail.com>

Backport-PR-URL: #29241
PR-URL: #28918
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Sep 19, 2019
Backport-PR-URL: #29241
PR-URL: #28918
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Sep 19, 2019
The following metadata has changed:

- v8dbg_class_ConsString__first__String
  - Class is now generated via torque.
  - Postmortem tools should use v8dbg_class_ConsString__first_offset__int
  - Refs: v8/v8@14274bb

- v8dbg_class_ConsString__second__String
  - Class is now generated via torque.
  - Postmortem tools should use v8dbg_class_ConsString__second_offset__int
  - Refs: v8/v8@14274bb

- v8dbg_class_SlicedString__offset__SMI
  - Class is now generated via torque.
  - Postmortem tools should use v8dbg_class_SlicedString__offset_offset__int
  - Refs: v8/v8@14274bb

- v8dbg_class_ThinString__actual__String
  - Class is now generated via torque.
  - Postmortem tools should use v8dbg_class_ThinString__actual_offset__int
  - Refs: v8/v8@14274bb

Backport-PR-URL: #29241
PR-URL: #28918
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Sep 19, 2019
Backport-PR-URL: #29241
PR-URL: #28918
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR added a commit that referenced this pull request Sep 24, 2019
Notable changes:

* crypto:
  * Add `oaepLabel` option #29489
* deps:
  * Update V8 to 7.7.299.11 #28918
    * More efficient memory handling
    * Stack trace serialization got faster
    * The `Intl.NumberFormat` API gained new functionality
    * For more information: https://v8.dev/blog/v8-release-77
* events:
  * Add support for `EventTarget` in `once`
    #29498
* fs:
  * Expose memory file mapping flag `UV_FS_O_FILEMAP`
    #29260
* inspector:
  * New API - `Session.connectToMainThread`
    #28870
* process:
  * Initial SourceMap support via `env.NODE_V8_COVERAGE`
    #28960
* stream:
  * Make `_write()` optional when `_writev()` is implemented
    #29639
* tls:
  * Add option to override signature algorithms
    #29598
* util:
  * Add `encodeInto` to `TextEncoder`
    #29524
* worker:
  * The `worker_thread` module is now stable
    #29512
@BridgeAR BridgeAR referenced this pull request Sep 24, 2019
BridgeAR added a commit that referenced this pull request Sep 25, 2019
Notable changes:

* crypto:
  * Add `oaepLabel` option #29489
* deps:
  * Update V8 to 7.7.299.11 #28918
    * More efficient memory handling
    * Stack trace serialization got faster
    * The `Intl.NumberFormat` API gained new functionality
    * For more information: https://v8.dev/blog/v8-release-77
* events:
  * Add support for `EventTarget` in `once`
    #29498
* fs:
  * Expose memory file mapping flag `UV_FS_O_FILEMAP`
    #29260
* inspector:
  * New API - `Session.connectToMainThread`
    #28870
* process:
  * Initial SourceMap support via `env.NODE_V8_COVERAGE`
    #28960
* stream:
  * Make `_write()` optional when `_writev()` is implemented
    #29639
* tls:
  * Add option to override signature algorithms
    #29598
* util:
  * Add `encodeInto` to `TextEncoder`
    #29524
* worker:
  * The `worker_thread` module is now stable
    #29512

PR-URL: #29695
BridgeAR added a commit that referenced this pull request Sep 25, 2019
Notable changes:

* crypto:
  * Add `oaepLabel` option #29489
* deps:
  * Update V8 to 7.7.299.11 #28918
    * More efficient memory handling
    * Stack trace serialization got faster
    * The `Intl.NumberFormat` API gained new functionality
    * For more information: https://v8.dev/blog/v8-release-77
* events:
  * Add support for `EventTarget` in `once`
    #29498
* fs:
  * Expose memory file mapping flag `UV_FS_O_FILEMAP`
    #29260
* inspector:
  * New API - `Session.connectToMainThread`
    #28870
* process:
  * Initial SourceMap support via `env.NODE_V8_COVERAGE`
    #28960
* stream:
  * Make `_write()` optional when `_writev()` is implemented
    #29639
* tls:
  * Add option to override signature algorithms
    #29598
* util:
  * Add `encodeInto` to `TextEncoder`
    #29524
* worker:
  * The `worker_thread` module is now stable
    #29512

PR-URL: #29695
BridgeAR added a commit that referenced this pull request Sep 25, 2019
Notable changes:

* crypto:
  * Add `oaepLabel` option #29489
* deps:
  * Update V8 to 7.7.299.11 #28918
    * More efficient memory handling
    * Stack trace serialization got faster
    * The `Intl.NumberFormat` API gained new functionality
    * For more information: https://v8.dev/blog/v8-release-77
* events:
  * Add support for `EventTarget` in `once`
    #29498
* fs:
  * Expose memory file mapping flag `UV_FS_O_FILEMAP`
    #29260
* inspector:
  * New API - `Session.connectToMainThread`
    #28870
* process:
  * Initial SourceMap support via `env.NODE_V8_COVERAGE`
    #28960
* stream:
  * Make `_write()` optional when `_writev()` is implemented
    #29639
* tls:
  * Add option to override signature algorithms
    #29598
* util:
  * Add `encodeInto` to `TextEncoder`
    #29524
* worker:
  * The `worker_thread` module is now stable
    #29512

PR-URL: #29695
Trott added a commit that referenced this pull request Sep 28, 2019
Builds from the source tarball were broken by the recent V8 upate
to 7.7 as a file needed to build torque wasn't included in the source
tarball as it resides in deps/v8/test.

PR-URL: #29712
Fixes: #29709
Refs: #28918
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
targos added a commit that referenced this pull request Oct 1, 2019
Builds from the source tarball were broken by the recent V8 upate
to 7.7 as a file needed to build torque wasn't included in the source
tarball as it resides in deps/v8/test.

PR-URL: #29712
Fixes: #29709
Refs: #28918
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.