Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: describe NODE_OPTIONS interop w/cmd line opts #28928

Closed
wants to merge 1 commit into from

Conversation

@A-lxe
Copy link
Contributor

commented Aug 1, 2019

Checklist
  • make lint passes
  • documentation is changed or added
  • commit message follows commit guidelines

Disambiguates the description of NODE_OPTIONS wrt how it is overrides/compounded by command line options. Adds examples of singleton and multi flags.

Fixes #28910

@lpinca
lpinca approved these changes Aug 1, 2019
NODE_OPTIONS='--require "./my path/file.js"'
```

A singleton flag passed as a command line option will *override* the same flag

This comment has been minimized.

Copy link
@Trott

Trott Aug 2, 2019

Member

Optional nit: No need for emphasis?

Suggested change
A singleton flag passed as a command line option will *override* the same flag
A singleton flag passed as a command line option will override the same flag

This comment has been minimized.

Copy link
@A-lxe

A-lxe Aug 2, 2019

Author Contributor

Removed the emphasis, but left singleton in -- happy to follow what you think on that, I think that it can work either way.

This comment has been minimized.

Copy link
@Trott

Trott Aug 3, 2019

Member

Yeah, I changed my mind and decided singleton was fine. If there's a better word, it can always be updated in a subsequent PR.

@Trott

This comment has been minimized.

@Trott Trott added the author ready label Aug 2, 2019

@Trott
Trott approved these changes Aug 2, 2019

@A-lxe A-lxe force-pushed the A-lxe:node-options-docs branch from 9e22ee2 to 6ae4a8f Aug 2, 2019

@A-lxe A-lxe force-pushed the A-lxe:node-options-docs branch from 6ae4a8f to 135407e Aug 2, 2019

@Trott

This comment has been minimized.

@cjihrig
cjihrig approved these changes Aug 3, 2019
@Trott

This comment has been minimized.

Copy link
Member

commented Aug 4, 2019

Landed in 5eaef7b

@Trott Trott closed this Aug 4, 2019

Trott added a commit to Trott/io.js that referenced this pull request Aug 4, 2019
doc: describe NODE_OPTIONS interop w/cmd line opts
Fixes nodejs#28910

PR-URL: nodejs#28928
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR added a commit that referenced this pull request Aug 6, 2019
doc: describe NODE_OPTIONS interop w/cmd line opts
Fixes #28910

PR-URL: #28928
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR referenced this pull request Aug 6, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc: describe NODE_OPTIONS interop w/cmd line opts
Fixes nodejs#28910

PR-URL: nodejs#28928
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc: describe NODE_OPTIONS interop w/cmd line opts
Fixes nodejs#28910

PR-URL: nodejs#28928
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.