Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor test-fs-stat.js #28929

Merged
merged 1 commit into from Aug 3, 2019

Conversation

@Trott
Copy link
Member

commented Aug 1, 2019

General code cleanup.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax addaleax added the fs label Aug 1, 2019

@nodejs-github-bot

This comment has been minimized.

@Trott Trott added the author ready label Aug 2, 2019

@nodejs-github-bot

This comment has been minimized.

@lpinca
lpinca approved these changes Aug 2, 2019
@cjihrig
cjihrig approved these changes Aug 3, 2019
test: refactor test-fs-stat.js
General code cleanup.

PR-URL: #28929
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@Trott Trott force-pushed the Trott:refactor-test-fs-stat branch from 8d771f1 to e6c2052 Aug 3, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Aug 3, 2019

Landed in e6c2052

@Trott Trott merged commit e6c2052 into nodejs:master Aug 3, 2019

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details
BridgeAR added a commit that referenced this pull request Aug 6, 2019
test: refactor test-fs-stat.js
General code cleanup.

PR-URL: #28929
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR referenced this pull request Aug 6, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
test: refactor test-fs-stat.js
General code cleanup.

PR-URL: nodejs#28929
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
test: refactor test-fs-stat.js
General code cleanup.

PR-URL: nodejs#28929
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.