Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conf: linux large pages LLVM lld linkage support #28938

Closed
wants to merge 1 commit into from

Conversation

@devnexen
Copy link
Contributor

commented Aug 2, 2019

The custom linker script is compatible with GNU ld only.
As such, providin a new expliciting option to redirect to
a different one. lld seems unable to migrate this
large section w/o segfaulting so providing only the
base address anchor for now.

@devnexen devnexen force-pushed the devnexen:large_pages_ld_support branch from cc4cc3c to d0c3498 Aug 2, 2019

@bnoordhuis
Copy link
Member

left a comment

Thanks, LGTM but can you keep lines <= 80 columns? In the .gypi you can write it like this:

['OS=="linux" and '
 'target_arch=="x64" and '
 'node_use_large_pages=="true" and '
 'node_use_large_pages_script_lld=="false"', {
  # ...
}
@bnoordhuis

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

@devnexen Are you a collaborator yet? If not, I'd be happy to nominate you.

build: linux large pages LLVM lld linkage support
The custom linker script is compatible with GNU ld only.
As such, providin a new expliciting option to redirect to
a different one. lld seems unable to migrate this
large section w/o segfaulting so providing only the
base address anchor for now.

@devnexen devnexen force-pushed the devnexen:large_pages_ld_support branch from d0c3498 to 46e39f8 Aug 6, 2019

@devnexen

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2019

Not yet indeed :)

@nodejs-github-bot

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

Landed in 0d7acfa

@Trott Trott closed this Aug 20, 2019

Trott added a commit that referenced this pull request Aug 20, 2019
build: enable linux large pages LLVM lld linkage support
The custom linker script is compatible with GNU ld only.
As such, providin a new expliciting option to redirect to
a different one. lld seems unable to migrate this
large section w/o segfaulting so providing only the
base address anchor for now.

PR-URL: #28938
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
targos added a commit that referenced this pull request Aug 20, 2019
build: enable linux large pages LLVM lld linkage support
The custom linker script is compatible with GNU ld only.
As such, providin a new expliciting option to redirect to
a different one. lld seems unable to migrate this
large section w/o segfaulting so providing only the
base address anchor for now.

PR-URL: #28938
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@targos targos referenced this pull request Aug 20, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
build: enable linux large pages LLVM lld linkage support
The custom linker script is compatible with GNU ld only.
As such, providin a new expliciting option to redirect to
a different one. lld seems unable to migrate this
large section w/o segfaulting so providing only the
base address anchor for now.

PR-URL: nodejs#28938
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
build: enable linux large pages LLVM lld linkage support
The custom linker script is compatible with GNU ld only.
As such, providin a new expliciting option to redirect to
a different one. lld seems unable to migrate this
large section w/o segfaulting so providing only the
base address anchor for now.

PR-URL: nodejs#28938
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.