Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: fix broken esm #28957

Closed
wants to merge 1 commit into from

Conversation

@ronag
Copy link
Contributor

commented Aug 4, 2019

Tries to fix blocked CITGM. See, standard-things/esm#821.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the fs label Aug 4, 2019

@ronag

This comment has been minimized.

Copy link
Contributor Author

commented Aug 4, 2019

@Trott: can I get a CITGM on this one?

@ronag ronag force-pushed the nxtedition:fix-esm branch from 79f928b to 5a3b88a Aug 4, 2019

@ronag ronag changed the title utils: fix broken esm fs: fix broken esm Aug 4, 2019

@ronag

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2019

@benjamingr can you start a CITGM on this one? ping @Trott

@mcollina

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

cc @jdalton wdyt?

@mcollina mcollina requested a review from joyeecheung Aug 6, 2019

@jdalton

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

LGTM as a workaround until a fix can be published.

@BridgeAR

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

@jdalton did your recent change in esm not fix the issue?

@BridgeAR
Copy link
Member

left a comment

LGTM as intermediate fix. This should definitely be removed as soon as possible though.

lib/internal/fs/utils.js Show resolved Hide resolved

@ronag ronag force-pushed the nxtedition:fix-esm branch from 5a3b88a to be8c546 Aug 6, 2019

@Trott
Trott approved these changes Aug 6, 2019
@Trott

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

@mcollina Looks good to you as a temporary measure?

@nodejs-github-bot

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

@mcollina
Copy link
Member

left a comment

LGTM as long as CITGM passes.

@trivikr
trivikr approved these changes Aug 6, 2019
Copy link
Member

left a comment

LGTM, one minor nit

@@ -345,6 +345,10 @@ function Stats(dev, mode, nlink, uid, gid, rdev, blksize,
Object.setPrototypeOf(Stats.prototype, StatsBase.prototype);
Object.setPrototypeOf(Stats, StatsBase);

// HACK: Workaround for https://github.com/standard-things/esm/issues/821.

This comment has been minimized.

Copy link
@trivikr

trivikr Aug 6, 2019

Member

nit: period becomes part of link

Suggested change
// HACK: Workaround for https://github.com/standard-things/esm/issues/821.
// HACK: Workaround for https://github.com/standard-things/esm/issues/821
@nodejs-github-bot

This comment has been minimized.

@Trott

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

CITGM master: 84 failures

CITM this PR: 29 failures

CI is green

This has two TSC approvals (necessary for semver-major)

Landing.

Trott added a commit to Trott/io.js that referenced this pull request Aug 7, 2019
fs: fix (temporary) for esm package
Fix to unblock CITGM. See,
standard-things/esm#821.

PR-URL: nodejs#28957
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

(@joyeecheung If you have an issue with this, we can revert it, of course.)

@Trott

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

Landed in 320402c

@Trott Trott closed this Aug 7, 2019

@joyeecheung

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

Belated LGTM and thanks for the ping!

@targos

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

Backport blocked by #21387

BridgeAR added a commit that referenced this pull request Sep 3, 2019
fs: fix (temporary) for esm package
Fix to unblock CITGM. See,
standard-things/esm#821.

PR-URL: #28957
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR referenced this pull request Sep 3, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
fs: fix (temporary) for esm package
Fix to unblock CITGM. See,
standard-things/esm#821.

PR-URL: nodejs#28957
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
fs: fix (temporary) for esm package
Fix to unblock CITGM. See,
standard-things/esm#821.

PR-URL: nodejs#28957
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.