Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: improve read() performance #28961

Closed
wants to merge 1 commit into from

Conversation

@mscdex
Copy link
Contributor

commented Aug 4, 2019

Result:

                                                        confidence improvement accuracy (*)   (**)   (***)
 streams/readable-readall.js n=5000                           ***     85.06 %       ±2.87% ±3.84%  ±5.05%
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

@targos
targos approved these changes Aug 5, 2019
@ronag

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

@mscdex Sorry to ask here. But, how do I generate/run that benchmark?

@mscdex

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

@ronag

Locally:

$ node benchmark/compare.js --new ./node --old ./node-master --filter readable-readall -- streams | Rscript benchmark/compare.R

or run it in benchmark CI and fill out some of the same parameters.

@ZYSzys
ZYSzys approved these changes Aug 5, 2019

@ZYSzys ZYSzys added the author ready label Aug 5, 2019

@trivikr
trivikr approved these changes Aug 5, 2019
@lpinca
lpinca approved these changes Aug 5, 2019
@cjihrig
cjihrig approved these changes Aug 5, 2019
@Trott
Trott approved these changes Aug 6, 2019
@Trott

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

@ronag After running the benchmark as @mscdex describes, you'll want to process the results via compare.R to get the output similar to what @mscdex has in the PR here and probably what you've seen elsewhere in the issue tracker. Further details about benchmarks and the associated scripts are in https://github.com/nodejs/node/blob/master/doc/guides/writing-and-running-benchmarks.md, especially https://github.com/nodejs/node/blob/master/doc/guides/writing-and-running-benchmarks.md#comparing-nodejs-versions.

@Trott

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

Oops, I see @mscdex included the R script at the end, so ignore that part of what I wrote. But the guide link may still come in handy.

@jasnell
jasnell approved these changes Aug 7, 2019
@Trott

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

Landed in 0b5b81c

@Trott Trott closed this Aug 7, 2019

Trott added a commit to Trott/io.js that referenced this pull request Aug 7, 2019
stream: improve read() performance
PR-URL: nodejs#28961
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@mscdex mscdex deleted the mscdex:streams-read-perf branch Aug 7, 2019

targos added a commit that referenced this pull request Aug 19, 2019
stream: improve read() performance
PR-URL: #28961
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Aug 19, 2019
stream: improve read() performance
PR-URL: #28961
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos referenced this pull request Aug 19, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
stream: improve read() performance
PR-URL: nodejs#28961
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
stream: improve read() performance
PR-URL: nodejs#28961
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.