Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix introduced_in note in querystring.md #29014

Closed

Conversation

@bnoordhuis
Copy link
Member

commented Aug 6, 2019

The method descriptions mentioned the right version but for some reason
the top-level description did not. Well, now it does.

doc: fix introduced_in note in querystring.md
The method descriptions mentioned the right version but for some reason
the top-level description did not. Well, now it does.
@cjihrig
cjihrig approved these changes Aug 6, 2019
@trivikr
trivikr approved these changes Aug 6, 2019
@lpinca
lpinca approved these changes Aug 6, 2019
@jasnell
jasnell approved these changes Aug 7, 2019
@danbev

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

@danbev

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

Landed in 0f8f4cd.

@danbev danbev closed this Aug 16, 2019

danbev added a commit that referenced this pull request Aug 16, 2019
doc: fix introduced_in note in querystring.md
The method descriptions mentioned the right version but for some reason
the top-level description did not. Well, now it does.

PR-URL: #29014
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Aug 19, 2019
doc: fix introduced_in note in querystring.md
The method descriptions mentioned the right version but for some reason
the top-level description did not. Well, now it does.

PR-URL: #29014
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Aug 19, 2019
doc: fix introduced_in note in querystring.md
The method descriptions mentioned the right version but for some reason
the top-level description did not. Well, now it does.

PR-URL: #29014
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos referenced this pull request Aug 19, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc: fix introduced_in note in querystring.md
The method descriptions mentioned the right version but for some reason
the top-level description did not. Well, now it does.

PR-URL: nodejs#29014
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc: fix introduced_in note in querystring.md
The method descriptions mentioned the right version but for some reason
the top-level description did not. Well, now it does.

PR-URL: nodejs#29014
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.