Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: buffer writes while no socket #29019

Closed

Conversation

@ronag
Copy link
Contributor

commented Aug 6, 2019

We should be buffering writes even while no socket is assigned.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ronag ronag force-pushed the nxtedition:http-buffer-even-while-no-socket branch 2 times, most recently from 7e038a5 to 6cc9e2f Aug 6, 2019

@ronag ronag changed the title http: buffer while no socket http: buffer writes while no socket Aug 6, 2019

@ronag ronag force-pushed the nxtedition:http-buffer-even-while-no-socket branch from 6cc9e2f to 292dac1 Aug 6, 2019

@ronag ronag referenced this pull request Aug 6, 2019
4 of 4 tasks complete
lib/_http_outgoing.js Outdated Show resolved Hide resolved
test/parallel/test-http-outgoing-buffer.js Outdated Show resolved Hide resolved
@lpinca

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

Seems good to me with the getHighWaterMark() issue addressed.

@ronag ronag force-pushed the nxtedition:http-buffer-even-while-no-socket branch 6 times, most recently from 6de1993 to 355f5b7 Aug 6, 2019

@ronag ronag force-pushed the nxtedition:http-buffer-even-while-no-socket branch 5 times, most recently from 53d503b to 0f8400b Aug 7, 2019

@lpinca
lpinca approved these changes Aug 8, 2019
@nodejs-github-bot

This comment has been minimized.

@ronag ronag force-pushed the nxtedition:http-buffer-even-while-no-socket branch from 0f8400b to d37b213 Aug 9, 2019

@nodejs-github-bot

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

@mcollina
Copy link
Member

left a comment

LGTM

@Trott

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

Landed in c065773

@Trott Trott closed this Aug 9, 2019

Trott added a commit to Trott/io.js that referenced this pull request Aug 9, 2019
http: buffer writes even while no socket assigned
PR-URL: nodejs#29019
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos added a commit that referenced this pull request Aug 19, 2019
http: buffer writes even while no socket assigned
PR-URL: #29019
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos added a commit that referenced this pull request Aug 19, 2019
http: buffer writes even while no socket assigned
PR-URL: #29019
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@targos targos referenced this pull request Aug 19, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
http: buffer writes even while no socket assigned
PR-URL: nodejs#29019
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
http: buffer writes even while no socket assigned
PR-URL: nodejs#29019
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.