Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix nits in child_process.md #29024

Closed

Conversation

@vsemozhetbyt
Copy link
Contributor

commented Aug 6, 2019

Checklist

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
  • Use console.error() for error or stderr output.
  • Unify comment style.
  • Unify link format.
  • Correct link URL.
  • Fix some typos.
@lpinca
lpinca approved these changes Aug 6, 2019
@@ -218,7 +218,7 @@ a `Promise` for an `Object` with `stdout` and `stderr` properties. The returned
`ChildProcess` instance is attached to the `Promise` as a `child` property. In
case of an error (including any error resulting in an exit code other than 0), a
rejected promise is returned, with the same `error` object given in the
callback, but with an additional two properties `stdout` and `stderr`.
callback, but with additional two properties `stdout` and `stderr`.

This comment has been minimized.

Copy link
@lpinca

lpinca Aug 6, 2019

Member
Suggested change
callback, but with additional two properties `stdout` and `stderr`.
callback, but with two additional properties `stdout` and `stderr`.
doc: fix nits in child_process.md
* Use `console.error()` for error or stderr output.
* Unify comment style.
* Unify link format.
* Correct link URL.
* Fix some typos.

@vsemozhetbyt vsemozhetbyt force-pushed the vsemozhetbyt:doc-child_process-nits branch from ba76266 to fdf42c2 Aug 6, 2019

@jasnell
jasnell approved these changes Aug 7, 2019
@cjihrig
cjihrig approved these changes Aug 7, 2019
@Trott
Trott approved these changes Aug 7, 2019
@Trott

This comment has been minimized.

@Trott Trott added the author ready label Aug 9, 2019

@Trott

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

Landed in bf692ce

@Trott Trott closed this Aug 9, 2019

Trott added a commit to Trott/io.js that referenced this pull request Aug 9, 2019
doc: fix nits in child_process.md
* Use `console.error()` for error or stderr output.
* Unify comment style.
* Unify link format.
* Correct link URL.
* Fix some typos.

PR-URL: nodejs#29024
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

@vsemozhetbyt vsemozhetbyt deleted the vsemozhetbyt:doc-child_process-nits branch Aug 9, 2019

targos added a commit that referenced this pull request Aug 19, 2019
doc: fix nits in child_process.md
* Use `console.error()` for error or stderr output.
* Unify comment style.
* Unify link format.
* Correct link URL.
* Fix some typos.

PR-URL: #29024
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Aug 19, 2019
doc: fix nits in child_process.md
* Use `console.error()` for error or stderr output.
* Unify comment style.
* Unify link format.
* Correct link URL.
* Fix some typos.

PR-URL: #29024
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos referenced this pull request Aug 19, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc: fix nits in child_process.md
* Use `console.error()` for error or stderr output.
* Unify comment style.
* Unify link format.
* Correct link URL.
* Fix some typos.

PR-URL: nodejs#29024
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc: fix nits in child_process.md
* Use `console.error()` for error or stderr output.
* Unify comment style.
* Unify link format.
* Correct link URL.
* Fix some typos.

PR-URL: nodejs#29024
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.