Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve UV_THREADPOOL_SIZE description #29033

Closed

Conversation

@tniessen
Copy link
Member

commented Aug 7, 2019

The UV_THREADPOOL_SIZE documentation claims that only three crypto APIs use the thread pool, which is not true anymore. This commit lists all relevant APIs and rephrases it such that future API additions are included in the documentation.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@cjihrig

cjihrig approved these changes Aug 7, 2019

@jasnell

jasnell approved these changes Aug 7, 2019

@Trott

Trott approved these changes Aug 7, 2019

@trivikr

trivikr approved these changes Aug 8, 2019

@Trott

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

@lpinca

lpinca approved these changes Aug 9, 2019

@tniessen

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2019

Landed in 885c644, thanks for reviewing!

@tniessen tniessen closed this Aug 9, 2019

tniessen added a commit that referenced this pull request Aug 9, 2019

doc: improve UV_THREADPOOL_SIZE description
PR-URL: #29033
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.