Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: unskip tests that now pass on AIX #29054

Closed
wants to merge 1 commit into from

Conversation

@sam-github
Copy link
Member

commented Aug 8, 2019

One skipped test remains, it creates very large Buffer objects,
triggering the AIX OOM to kill node and it's parent processes.

See: nodejs/build#1849 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@sam-github sam-github force-pushed the sam-github:unskip-aix branch from b451176 to 260d3bc Aug 8, 2019

@nodejs-github-bot

This comment has been minimized.

@cjihrig
cjihrig approved these changes Aug 8, 2019
@lpinca
lpinca approved these changes Aug 8, 2019
@Trott
Trott approved these changes Aug 8, 2019
@nodejs-github-bot

This comment has been minimized.

test: unskip tests that now pass on AIX
One skipped test remains, it creates very large Buffer objects,
triggering the AIX OOM to kill node and its parent processes.

See: nodejs/build#1849 (comment)

@sam-github sam-github force-pushed the sam-github:unskip-aix branch from 260d3bc to 79548b9 Aug 9, 2019

@nodejs-github-bot

This comment has been minimized.

@sam-github

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2019

2 CIs in a row were green. kicked off a last, but this is looking good.

@Trott

This comment has been minimized.

Copy link
Member

commented Aug 11, 2019

Landed in c146f88

@Trott Trott closed this Aug 11, 2019

Trott added a commit to Trott/io.js that referenced this pull request Aug 11, 2019
test: unskip tests that now pass on AIX
One skipped test remains, it creates very large Buffer objects,
triggering the AIX OOM to kill node and its parent processes.

See: nodejs/build#1849 (comment)

PR-URL: nodejs#29054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos added a commit that referenced this pull request Aug 19, 2019
test: unskip tests that now pass on AIX
One skipped test remains, it creates very large Buffer objects,
triggering the AIX OOM to kill node and its parent processes.

See: nodejs/build#1849 (comment)

PR-URL: #29054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos added a commit that referenced this pull request Aug 19, 2019
test: unskip tests that now pass on AIX
One skipped test remains, it creates very large Buffer objects,
triggering the AIX OOM to kill node and its parent processes.

See: nodejs/build#1849 (comment)

PR-URL: #29054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@targos targos referenced this pull request Aug 19, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
test: unskip tests that now pass on AIX
One skipped test remains, it creates very large Buffer objects,
triggering the AIX OOM to kill node and its parent processes.

See: nodejs/build#1849 (comment)

PR-URL: nodejs#29054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
test: unskip tests that now pass on AIX
One skipped test remains, it creates very large Buffer objects,
triggering the AIX OOM to kill node and its parent processes.

See: nodejs/build#1849 (comment)

PR-URL: nodejs#29054
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.