Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted typo fixes. #29075

Closed
wants to merge 1 commit into from

Conversation

@XhmikosR
Copy link
Contributor

commented Aug 10, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@mscdex

This comment has been minimized.

Copy link
Contributor

commented Aug 10, 2019

As far as at least commit messages in changelogs go, we usually leave those alone, even if there were spelling mistakes.

@XhmikosR

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2019

It's a semi-automated fix, so this was easier for me...

@XhmikosR

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2019

For the site nodejs/nodejs.org#2375

@XhmikosR

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2019

Regardless, I can revert the commit message changes here and in the website PR if you guys prefer that.

@XhmikosR XhmikosR referenced this pull request Aug 10, 2019
@mcollina
Copy link
Member

left a comment

The changes to the changelog files are still there

@XhmikosR

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2019

@XhmikosR

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2019

Done.

@Trott
Trott approved these changes Aug 10, 2019
@lpinca
lpinca approved these changes Aug 10, 2019
@Trott

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

Landed in f114e5b

@Trott Trott closed this Aug 12, 2019

Trott added a commit to Trott/io.js that referenced this pull request Aug 12, 2019
doc, lib, src, test, tools: fix assorted typos
PR-URL: nodejs#29075
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@XhmikosR XhmikosR deleted the XhmikosR:master-xmr-typo-fixes branch Aug 13, 2019

targos added a commit that referenced this pull request Aug 19, 2019
doc, lib, src, test, tools: fix assorted typos
PR-URL: #29075
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos added a commit that referenced this pull request Aug 19, 2019
doc, lib, src, test, tools: fix assorted typos
PR-URL: #29075
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos referenced this pull request Aug 19, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc, lib, src, test, tools: fix assorted typos
PR-URL: nodejs#29075
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc, lib, src, test, tools: fix assorted typos
PR-URL: nodejs#29075
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.