Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: symbol naming convention #29091

Closed
wants to merge 1 commit into from

Conversation

@ronag
Copy link
Contributor

commented Aug 12, 2019

Follow the naming convention for symbols.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@ronag ronag referenced this pull request Aug 12, 2019
4 of 4 tasks complete
@legendecas
Copy link
Contributor

left a comment

Is there any written rules for naming a variable of various types?

@ronag

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

@legendecas: Not that I'm aware of. But it's the convention used in the rest of the code.

@ronag ronag force-pushed the nxtedition:http-out-headers-key branch 5 times, most recently from 566f9aa to 945b126 Aug 12, 2019

@ronag

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

@Trott: flaky test?

@nodejs-github-bot

This comment has been minimized.

@lpinca
lpinca approved these changes Aug 12, 2019
lib/internal/http.js Outdated Show resolved Hide resolved
@nodejs-github-bot

This comment has been minimized.

@ronag ronag force-pushed the nxtedition:http-out-headers-key branch from 945b126 to 0bdebc9 Aug 12, 2019

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@Trott
Trott approved these changes Aug 14, 2019
Trott added a commit to Trott/io.js that referenced this pull request Aug 14, 2019
http: follow symbol naming convention
PR-URL: nodejs#29091
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

Landed in d303548

@Trott Trott closed this Aug 14, 2019

targos added a commit that referenced this pull request Aug 19, 2019
http: follow symbol naming convention
PR-URL: #29091
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Aug 19, 2019
http: follow symbol naming convention
PR-URL: #29091
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos referenced this pull request Aug 19, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
http: follow symbol naming convention
PR-URL: nodejs#29091
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
http: follow symbol naming convention
PR-URL: nodejs#29091
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.