Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exported method can be static; will never be called directly #29102

Closed
wants to merge 1 commit into from

Conversation

@rpoisel
Copy link
Contributor

commented Aug 13, 2019

Checklist
@patilharshal16
Copy link

left a comment

Do we need static method?

@rpoisel

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

No, you don't need it, but you might want it (encapsulation principle). :-)

I don't see any reason for having this being a symbol with global scope (as opposed to: module scope).

@addaleax

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

I think this is okay, but since these are test addons, it really doesn’t make a difference in practice.

@rpoisel rpoisel force-pushed the rpoisel:pr-hello-static branch from 7e7f42f to 373aa3a Aug 13, 2019

@rpoisel rpoisel force-pushed the rpoisel:pr-hello-static branch from 373aa3a to 9209b14 Aug 13, 2019

@Trott
Trott approved these changes Aug 16, 2019
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

Landed in 71b5ce5

@Trott Trott closed this Aug 16, 2019

Trott added a commit to Trott/io.js that referenced this pull request Aug 16, 2019
test: make exported method static
The exported method can be static as it will never be called directly.

PR-URL: nodejs#29102
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Aug 19, 2019
test: make exported method static
The exported method can be static as it will never be called directly.

PR-URL: #29102
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Aug 19, 2019
test: make exported method static
The exported method can be static as it will never be called directly.

PR-URL: #29102
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos referenced this pull request Aug 19, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
test: make exported method static
The exported method can be static as it will never be called directly.

PR-URL: nodejs#29102
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
test: make exported method static
The exported method can be static as it will never be called directly.

PR-URL: nodejs#29102
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.