Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add required settings to test-benchmark-buffer #29163

Merged
merged 0 commits into from Aug 16, 2019

Conversation

@Trott
Copy link
Member

commented Aug 16, 2019

A benchmark was added but the appropriate settings were not added to
test-benchmark-buffer. These two additions make sure that the new
benchmark file only runs a single benchmark during testing.

node-daily-master on CI will be broken until this lands. 馃憤 here to fast-track if you're a Collaborator.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@Trott

This comment has been minimized.

Copy link
Member Author

commented Aug 16, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3834/ 鉁旓笍

Benchmark Test CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/8565/ 鉁旓笍

Benchmark tests do not get run in regular CI, so a full regular CI run should not be necessary.

@ZYSzys
ZYSzys approved these changes Aug 16, 2019
@ZYSzys
ZYSzys approved these changes Aug 16, 2019
@Trott

This comment has been minimized.

Copy link
Member Author

commented Aug 16, 2019

Landed in b9ff6a3

@Trott Trott closed this Aug 16, 2019

@Trott Trott force-pushed the Trott:fix-buffer-benchmark-test branch from b997840 to b9ff6a3 Aug 16, 2019

@Trott Trott merged commit b9ff6a3 into nodejs:master Aug 16, 2019

1 check passed

Travis CI - Branch Build Passed
Details
targos added a commit that referenced this pull request Aug 19, 2019
test: add required settings to test-benchmark-buffer
A benchmark was added but the appropriate settings were not added to
test-benchmark-buffer. These two additions make sure that the new
benchmark file only runs a single benchmark during testing.

PR-URL: #29163
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos added a commit that referenced this pull request Aug 19, 2019
test: add required settings to test-benchmark-buffer
A benchmark was added but the appropriate settings were not added to
test-benchmark-buffer. These two additions make sure that the new
benchmark file only runs a single benchmark during testing.

PR-URL: #29163
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@targos targos referenced this pull request Aug 19, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
test: add required settings to test-benchmark-buffer
A benchmark was added but the appropriate settings were not added to
test-benchmark-buffer. These two additions make sure that the new
benchmark file only runs a single benchmark during testing.

PR-URL: nodejs#29163
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
test: add required settings to test-benchmark-buffer
A benchmark was added but the appropriate settings were not added to
test-benchmark-buffer. These two additions make sure that the new
benchmark file only runs a single benchmark during testing.

PR-URL: nodejs#29163
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.