Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: make pty_helper.py python3-compatible #29167

Closed
wants to merge 1 commit into from

Conversation

@bnoordhuis
Copy link
Member

commented Aug 16, 2019

@nodejs-github-bot

This comment has been minimized.

@bnoordhuis

This comment has been minimized.

Copy link
Member Author

commented Aug 16, 2019

I suppose the proper prefix is 'test:' because the script lives in test/pseudo-tty. It's invoked by tools/test.py though.

@sam-github

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

Isn't covered by current tests, since they just do py2, but I did a python3 tools/test.py -J pseudo-tty and it works.

@sam-github sam-github requested a review from cclauss Aug 16, 2019

@cclauss cclauss referenced this pull request Aug 16, 2019
29 of 41 tasks complete
@Trott
Trott approved these changes Aug 18, 2019

@Trott Trott added the author ready label Aug 19, 2019

@Trott

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

Landed in 9c27118

@Trott Trott closed this Aug 19, 2019

Trott added a commit that referenced this pull request Aug 19, 2019
tools: make pty_helper.py python3-compatible
Fixes: #29166

PR-URL: #29167
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Aug 20, 2019
tools: make pty_helper.py python3-compatible
Fixes: #29166

PR-URL: #29167
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos referenced this pull request Aug 20, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
tools: make pty_helper.py python3-compatible
Fixes: nodejs#29166

PR-URL: nodejs#29167
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
tools: make pty_helper.py python3-compatible
Fixes: nodejs#29166

PR-URL: nodejs#29167
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.