Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove unnecessary Python semicolon #29170

Merged
merged 0 commits into from Aug 18, 2019

Conversation

@Trott
Copy link
Member

commented Aug 16, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@MattIPv4
Copy link
Contributor

left a comment

Lgtm.

@Trott Trott added the python label Aug 16, 2019

@nodejs-github-bot

This comment has been minimized.

@richardlau

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

(This file isn't run as part of the regular builds so a lite-CI would have been sufficient. It is used to generate deps/icu-small (e.g. on ICU updates see https://github.com/nodejs/node/blob/master/tools/icu/README.md).)

@Trott Trott added the author ready label Aug 16, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Aug 18, 2019

Landed in 27b7656

@Trott Trott closed this Aug 18, 2019

@Trott Trott force-pushed the Trott:semipy branch from ccc9e75 to 27b7656 Aug 18, 2019

@Trott Trott merged commit 27b7656 into nodejs:master Aug 18, 2019

1 check passed

Travis CI - Branch Build Passed
Details
targos added a commit that referenced this pull request Aug 19, 2019
build: remove unnecessary Python semicolon
PR-URL: #29170
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos added a commit that referenced this pull request Aug 19, 2019
build: remove unnecessary Python semicolon
PR-URL: #29170
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos referenced this pull request Aug 19, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
build: remove unnecessary Python semicolon
PR-URL: nodejs#29170
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
build: remove unnecessary Python semicolon
PR-URL: nodejs#29170
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.