Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
stream: async iterator destroy compat #29176
The biggest issue I have with this is that it's undocumented and monkey patched
There are a few
An alternative is to make it documented and part of the public API? Also, I wouldn't mind fixing the once that are streams.
Yep. I can see it now. Classes that inherit from streams use it sometimes. But it doesn't ever seem to be used outside of the implementation (except for the case with this PR).
We might want to consider refactoring that and calling the method something else hidden behind a symbol.