Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: use callback to properly propagate error #29178

Closed
wants to merge 1 commit into from

Conversation

@ronag
Copy link
Contributor

commented Aug 17, 2019

The socket will be destroyed upstream through the proper error
flow.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
net: use callback to properly propagate error
The socket will be destroyed upstream through the proper error
flow.
@ronag ronag referenced this pull request Aug 17, 2019
0 of 5 tasks complete
@lpinca
lpinca approved these changes Aug 18, 2019
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

Out of extra caution....

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1968/ (queued)

@Trott

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

Landed in cc7cec2

@Trott Trott closed this Aug 20, 2019

Trott added a commit that referenced this pull request Aug 20, 2019
net: use callback to properly propagate error
The socket will be destroyed upstream through the proper error
flow.

PR-URL: #29178
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Aug 20, 2019
net: use callback to properly propagate error
The socket will be destroyed upstream through the proper error
flow.

PR-URL: #29178
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos referenced this pull request Aug 20, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
net: use callback to properly propagate error
The socket will be destroyed upstream through the proper error
flow.

PR-URL: nodejs#29178
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
net: use callback to properly propagate error
The socket will be destroyed upstream through the proper error
flow.

PR-URL: nodejs#29178
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.