Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs: use fs.writev #29189

Closed
wants to merge 1 commit into from

Conversation

@ronag
Copy link
Contributor

commented Aug 17, 2019

Avoid using internal API in fs implementation.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
fs: use fs.writev
Avoid using internal API in fs implementation.
@Trott
Trott approved these changes Aug 17, 2019
Copy link
Member

left a comment

LGTM if CI passes

@nodejs-github-bot

This comment has been minimized.

@lpinca
lpinca approved these changes Aug 18, 2019
@nodejs-github-bot

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

Landed in 490ec9b

@Trott Trott closed this Aug 20, 2019

Trott added a commit that referenced this pull request Aug 20, 2019
fs: use fs.writev() internally
Avoid using internal API in fs implementation.

PR-URL: #29189
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos added a commit that referenced this pull request Aug 20, 2019
fs: use fs.writev() internally
Avoid using internal API in fs implementation.

PR-URL: #29189
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos referenced this pull request Aug 20, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
fs: use fs.writev() internally
Avoid using internal API in fs implementation.

PR-URL: nodejs#29189
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
fs: use fs.writev() internally
Avoid using internal API in fs implementation.

PR-URL: nodejs#29189
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.