Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: simplify timeout handling #29200

Closed

Conversation

@ronag
Copy link
Contributor

commented Aug 19, 2019

Avoids allocating and registering extra listeners for 'timeout'.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

@ronag ronag force-pushed the nxtedition:http-client-req-timeout-refactor branch from 58a84b6 to 2c4cc01 Aug 19, 2019

http: simplify timeout handling
Avoids allocating and registering extra listeners for 'timeout'.

@ronag ronag force-pushed the nxtedition:http-client-req-timeout-refactor branch from 2c4cc01 to 6f54858 Aug 19, 2019

@lpinca
lpinca approved these changes Aug 19, 2019
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@lpinca

This comment has been minimized.

Copy link
Member

commented Aug 31, 2019

Landed in cad3a21.

lpinca added a commit that referenced this pull request Aug 31, 2019
http: simplify timeout handling
Avoids allocating and registering extra listeners for 'timeout'.

PR-URL: #29200
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

@lpinca lpinca closed this Aug 31, 2019

BridgeAR added a commit that referenced this pull request Sep 3, 2019
http: simplify timeout handling
Avoids allocating and registering extra listeners for 'timeout'.

PR-URL: #29200
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR referenced this pull request Sep 3, 2019
BridgeAR added a commit that referenced this pull request Sep 4, 2019
http: simplify timeout handling
Avoids allocating and registering extra listeners for 'timeout'.

PR-URL: #29200
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
http: simplify timeout handling
Avoids allocating and registering extra listeners for 'timeout'.

PR-URL: nodejs#29200
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
http: simplify timeout handling
Avoids allocating and registering extra listeners for 'timeout'.

PR-URL: nodejs#29200
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.