Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fix mixup with bytes.decode() and str.encode() #29208

Closed
wants to merge 1 commit into from

Conversation

@cclauss
Copy link
Contributor

commented Aug 19, 2019

We want to read a bytes file and decode the contents as utf-8 so we can compare against a utf-8 pattern.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@cclauss cclauss requested a review from refack Aug 19, 2019

@targos

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

Subsystem should be "tools"

@cclauss cclauss referenced this pull request Aug 19, 2019
29 of 41 tasks complete

@cclauss cclauss added the python label Aug 19, 2019

@addaleax addaleax changed the title v8: fix mixup with bytes.decode() and str.encode() tools: fix mixup with bytes.decode() and str.encode() Aug 20, 2019

@targos
targos approved these changes Aug 20, 2019
Copy link
Member

left a comment

LGTM. That's exactly what we have in canary-base

@nodejs-github-bot

This comment has been minimized.

@cclauss cclauss force-pushed the GN-scraper.decode branch from 1562072 to 4816f7c Aug 20, 2019

tools: fix mixup with bytes.decode() and str.encode()
We want to read a bytes file and decode the contents as utf-8 so we can compare against a utf-8 pattern.

@cclauss cclauss force-pushed the GN-scraper.decode branch from 4816f7c to ecda222 Aug 21, 2019

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@Trott

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

Landed in 6afd1a3

@Trott Trott closed this Aug 22, 2019

Trott added a commit that referenced this pull request Aug 22, 2019
tools: fix mixup with bytes.decode() and str.encode()
We want to read a bytes file and decode the contents as utf-8 so we can
compare against a utf-8 pattern.

PR-URL: #29208
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

@cclauss cclauss deleted the GN-scraper.decode branch Aug 22, 2019

ronag added a commit to nxtedition/node that referenced this pull request Aug 23, 2019
tools: fix mixup with bytes.decode() and str.encode()
We want to read a bytes file and decode the contents as utf-8 so we can
compare against a utf-8 pattern.

PR-URL: nodejs#29208
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
BridgeAR added a commit that referenced this pull request Sep 3, 2019
tools: fix mixup with bytes.decode() and str.encode()
We want to read a bytes file and decode the contents as utf-8 so we can
compare against a utf-8 pattern.

PR-URL: #29208
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@BridgeAR BridgeAR referenced this pull request Sep 3, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
tools: fix mixup with bytes.decode() and str.encode()
We want to read a bytes file and decode the contents as utf-8 so we can
compare against a utf-8 pattern.

PR-URL: nodejs#29208
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
tools: fix mixup with bytes.decode() and str.encode()
We want to read a bytes file and decode the contents as utf-8 so we can
compare against a utf-8 pattern.

PR-URL: nodejs#29208
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.