Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add missing extends Http2Session #29252

Closed
wants to merge 1 commit into from

Conversation

@trivikr
Copy link
Member

commented Aug 21, 2019

adds missing extends Http2Session for ClientHttp2Session and ServerHttp2Session

Checklist
doc: add missing extends Http2Session
adds missing extends Http2Session for ClientHttp2Session
and ServerHttp2Session
@trivikr

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2019

@lpinca
lpinca approved these changes Aug 21, 2019

@trivikr trivikr self-assigned this Aug 22, 2019

@Trott

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

Landed in 2b1bcba

@Trott Trott closed this Aug 23, 2019

Trott added a commit that referenced this pull request Aug 23, 2019
doc: add missing extends Http2Session
Adds missing extends Http2Session for ClientHttp2Session
and ServerHttp2Session.

PR-URL: #29252
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

@trivikr trivikr deleted the trivikr:extends-http2session branch Aug 23, 2019

BridgeAR added a commit that referenced this pull request Sep 3, 2019
doc: add missing extends Http2Session
Adds missing extends Http2Session for ClientHttp2Session
and ServerHttp2Session.

PR-URL: #29252
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR referenced this pull request Sep 3, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc: add missing extends Http2Session
Adds missing extends Http2Session for ClientHttp2Session
and ServerHttp2Session.

PR-URL: nodejs#29252
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc: add missing extends Http2Session
Adds missing extends Http2Session for ClientHttp2Session
and ServerHttp2Session.

PR-URL: nodejs#29252
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.