Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update Http2ServerRequest extends Readable #29253

Closed
wants to merge 1 commit into from

Conversation

@trivikr
Copy link
Member

commented Aug 21, 2019

This PR also removes the redundant statement explained by "extends stream.Readable"

Checklist
@trivikr

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2019

@lpinca
lpinca approved these changes Aug 21, 2019
@trivikr

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2019

@trivikr trivikr force-pushed the trivikr:extends-stream-Readable branch from 8daf178 to d28eb8f Aug 21, 2019

@trivikr trivikr changed the title doc: Http2ServerRequest extends stream.Readable doc: update Http2ServerRequest extends Readable Aug 21, 2019

@trivikr trivikr self-assigned this Aug 22, 2019

@trivikr

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2019

@Trott

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3851/

Merge commit might mess it up. I'll rebase and re-run if so.

@Trott Trott force-pushed the trivikr:extends-stream-Readable branch from 5a5c1b6 to 3f1d9ed Aug 23, 2019

@Trott

This comment has been minimized.

Trott added a commit that referenced this pull request Aug 23, 2019
doc: indicate that Http2ServerRequest extends Readable
PR-URL: #29253
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

Landed in 31c3fc0

@Trott Trott closed this Aug 23, 2019

@trivikr trivikr deleted the trivikr:extends-stream-Readable branch Aug 23, 2019

BridgeAR added a commit that referenced this pull request Sep 3, 2019
doc: indicate that Http2ServerRequest extends Readable
PR-URL: #29253
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BridgeAR BridgeAR referenced this pull request Sep 3, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc: indicate that Http2ServerRequest extends Readable
PR-URL: nodejs#29253
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc: indicate that Http2ServerRequest extends Readable
PR-URL: nodejs#29253
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.