Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update Http2ServerResponse extends Stream #29254

Closed

Conversation

@trivikr
Copy link
Member

commented Aug 21, 2019

also removes the redundant statement explained by "extends Stream"

Checklist
@trivikr

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2019

doc: update Http2ServerResponse extends Stream
also removes the redundant statement explained by "extends Stream"

@trivikr trivikr force-pushed the trivikr:http2ServerResponse-extends-stream branch from 8d9b4ea to fcbb258 Aug 21, 2019

@trivikr trivikr changed the title doc: Http2ServerResponse extends Stream doc: update Http2ServerResponse extends Stream Aug 21, 2019

@trivikr

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2019

@trivikr trivikr self-assigned this Aug 22, 2019

@Trott

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

Landed in 824b3e2

@Trott Trott closed this Aug 23, 2019

Trott added a commit that referenced this pull request Aug 23, 2019
doc: indicate that Http2ServerResponse extends Stream
Also removes the redundant statement explained by "extends Stream".

PR-URL: #29254
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

@trivikr trivikr deleted the trivikr:http2ServerResponse-extends-stream branch Aug 23, 2019

BridgeAR added a commit that referenced this pull request Sep 3, 2019
doc: indicate that Http2ServerResponse extends Stream
Also removes the redundant statement explained by "extends Stream".

PR-URL: #29254
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@BridgeAR BridgeAR referenced this pull request Sep 3, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc: indicate that Http2ServerResponse extends Stream
Also removes the redundant statement explained by "extends Stream".

PR-URL: nodejs#29254
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc: indicate that Http2ServerResponse extends Stream
Also removes the redundant statement explained by "extends Stream".

PR-URL: nodejs#29254
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.