Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc,http: add extends for derived classes #29255

Closed
wants to merge 1 commit into from

Conversation

@trivikr
Copy link
Member

commented Aug 21, 2019

also removed redundant statments as extends is self-explanatory

Checklist
doc,http: add extends for derived classes
also removed redundant statments as extends is self-explanatory
@trivikr

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2019

@lpinca
lpinca approved these changes Aug 22, 2019

@trivikr trivikr self-assigned this Aug 22, 2019

@Trott

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

Landed in d27cc1b

@Trott Trott closed this Aug 23, 2019

Trott added a commit that referenced this pull request Aug 23, 2019
doc,http: add extends for derived classes
Also removed redundant statments as extends is self-explanatory.

PR-URL: #29255
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

@trivikr trivikr deleted the trivikr:http-doc-extends branch Aug 23, 2019

BridgeAR added a commit that referenced this pull request Sep 3, 2019
doc,http: add extends for derived classes
Also removed redundant statments as extends is self-explanatory.

PR-URL: #29255
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR referenced this pull request Sep 3, 2019
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc,http: add extends for derived classes
Also removed redundant statments as extends is self-explanatory.

PR-URL: nodejs#29255
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc,http: add extends for derived classes
Also removed redundant statments as extends is self-explanatory.

PR-URL: nodejs#29255
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.