Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: remove listeners from free sockets #29259

Closed
wants to merge 2 commits into from

Conversation

@ronag
Copy link
Member

ronag commented Aug 21, 2019

This is a continuation on #29245 made in a separate PR to make #29245 easier to fast track if desired.

Some more listener cleanup when sockets are detached from the request object and moved into the socket pool.

I'm not sure, but this looks like it might actually be a bug?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
@ronag ronag force-pushed the nxtedition:http-free-listener branch 2 times, most recently from 81282c4 to 94a1aa9 Aug 21, 2019
@ronag ronag changed the title Http free listener http: remove listeners from free sockets Aug 21, 2019
@ronag ronag force-pushed the nxtedition:http-free-listener branch from 94a1aa9 to da31643 Aug 22, 2019
@Trott Trott force-pushed the nodejs:master branch from e460838 to 775048d Aug 22, 2019
Copy link
Member

addaleax left a comment

LGTM, but this needs a rebase

@ronag ronag force-pushed the nxtedition:http-free-listener branch from da31643 to f9ba882 Aug 25, 2019
@ronag

This comment has been minimized.

Copy link
Member Author

ronag commented Aug 25, 2019

Rebased

@nodejs-github-bot

This comment has been minimized.

@Trott Trott removed the author ready label Sep 9, 2019
@Trott Trott force-pushed the nodejs:master branch from 1ecc406 to 49cf67e Sep 17, 2019
@ronag

This comment has been minimized.

Copy link
Member Author

ronag commented Sep 23, 2019

rebased

@ronag ronag force-pushed the nxtedition:http-free-listener branch 2 times, most recently from 05988bf to f9486be Sep 23, 2019
ronag added 2 commits Aug 21, 2019
Reduced memory usage by ensuring free sockets don't have extra
listeners while in the pool.
@ronag ronag force-pushed the nxtedition:http-free-listener branch from e67d546 to 5c6b99f Sep 23, 2019
@ronag ronag requested a review from mcollina Nov 11, 2019
Copy link
Member

mcollina left a comment

LGTM

@ronag

This comment has been minimized.

Copy link
Member Author

ronag commented Dec 29, 2019

@Trott: Can this land?

@Trott
Trott approved these changes Dec 30, 2019
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment has been minimized.

Copy link

nodejs-github-bot commented Jan 2, 2020

BridgeAR added a commit that referenced this pull request Jan 3, 2020
Reduced memory usage by ensuring free sockets don't have extra
listeners while in the pool.

PR-URL: #29259
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR

This comment has been minimized.

Copy link
Member

BridgeAR commented Jan 3, 2020

Landed in 7c70dbb 🎉

@BridgeAR BridgeAR closed this Jan 3, 2020
BridgeAR added a commit that referenced this pull request Jan 3, 2020
Reduced memory usage by ensuring free sockets don't have extra
listeners while in the pool.

PR-URL: #29259
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
targos added a commit that referenced this pull request Jan 14, 2020
Reduced memory usage by ensuring free sockets don't have extra
listeners while in the pool.

PR-URL: #29259
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos added a commit that referenced this pull request Jan 14, 2020
Reduced memory usage by ensuring free sockets don't have extra
listeners while in the pool.

PR-URL: #29259
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.