Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fix Python 3 issues in inspector_protocol #29296

Closed

Conversation

@cclauss
Copy link
Contributor

commented Aug 24, 2019

bytes and str changes to inspector_protocol for Python 3 compatibility.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@cclauss cclauss requested review from Trott, targos and bnoordhuis Aug 24, 2019

@cclauss cclauss added the python label Aug 24, 2019

@cclauss cclauss requested a review from trivikr Aug 24, 2019

@nodejs-github-bot

This comment has been minimized.

@cclauss cclauss referenced this pull request Aug 24, 2019
29 of 41 tasks complete

@cclauss cclauss requested a review from richardlau Aug 24, 2019

@Trott

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

Landed in 4662f67

@Trott Trott closed this Aug 27, 2019

Trott added a commit that referenced this pull request Aug 27, 2019
tools: fix Python 3 issues in inspector_protocol
PR-URL: #29296
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

@cclauss cclauss deleted the cclauss:py3_fixes_in_inspector_protocol branch Aug 27, 2019

BridgeAR added a commit that referenced this pull request Sep 3, 2019
tools: fix Python 3 issues in inspector_protocol
PR-URL: #29296
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR referenced this pull request Sep 3, 2019
BridgeAR added a commit that referenced this pull request Sep 4, 2019
tools: fix Python 3 issues in inspector_protocol
PR-URL: #29296
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
tools: fix Python 3 issues in inspector_protocol
PR-URL: nodejs#29296
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
tools: fix Python 3 issues in inspector_protocol
PR-URL: nodejs#29296
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.