Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc,crypto: add extends for derived classes #29302

Merged
merged 1 commit into from Aug 29, 2019

Conversation

@trivikr
Copy link
Member

commented Aug 25, 2019

Checklist
@trivikr

This comment has been minimized.

Copy link
Member Author

commented Aug 26, 2019

@trivikr trivikr self-assigned this Aug 26, 2019

@lpinca
lpinca approved these changes Aug 26, 2019
@lpinca
lpinca approved these changes Aug 26, 2019
doc/api/crypto.md Outdated Show resolved Hide resolved
doc/api/crypto.md Outdated Show resolved Hide resolved
doc/api/crypto.md Outdated Show resolved Hide resolved
doc/api/crypto.md Outdated Show resolved Hide resolved

@trivikr trivikr removed the author ready label Aug 26, 2019

@trivikr

This comment has been minimized.

Copy link
Member Author

commented Aug 26, 2019

@trivikr

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2019

@trivikr trivikr referenced this pull request Aug 27, 2019
7 of 7 tasks complete
@trivikr

This comment has been minimized.

Copy link
Member Author

commented Aug 28, 2019

@Trott

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

@trivikr Any reason to hold off on landing this?

@trivikr

This comment has been minimized.

Copy link
Member Author

commented Aug 29, 2019

Yet to get approvals after latest commit ce60c8c
Ping @jasnell @lpinca

@lpinca
lpinca approved these changes Aug 29, 2019
doc,crypto: add extends for derived classes
PR-URL: #29302
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@trivikr trivikr force-pushed the trivikr:doc-crypto-extends branch from ce60c8c to c746ba4 Aug 29, 2019

@trivikr

This comment has been minimized.

Copy link
Member Author

commented Aug 29, 2019

Landed in c746ba4

@trivikr trivikr merged commit c746ba4 into nodejs:master Aug 29, 2019

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details

@trivikr trivikr deleted the trivikr:doc-crypto-extends branch Aug 29, 2019

BridgeAR added a commit that referenced this pull request Sep 3, 2019
doc,crypto: add extends for derived classes
PR-URL: #29302
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR referenced this pull request Sep 3, 2019
BridgeAR added a commit that referenced this pull request Sep 4, 2019
doc,crypto: add extends for derived classes
PR-URL: #29302
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc,crypto: add extends for derived classes
PR-URL: nodejs#29302
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc,crypto: add extends for derived classes
PR-URL: nodejs#29302
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.