Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc,errors: add extends to derived classes #29303

Merged
merged 1 commit into from Aug 27, 2019

Conversation

@trivikr
Copy link
Member

commented Aug 25, 2019

Checklist
tools/doc/type-parser.js Outdated Show resolved Hide resolved
@lpinca
lpinca approved these changes Aug 26, 2019
@trivikr

This comment has been minimized.

Copy link
Member Author

commented Aug 26, 2019

@trivikr trivikr self-assigned this Aug 26, 2019

doc,errors: add extends to derived classes
PR-URL: #29303
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

@trivikr trivikr force-pushed the trivikr:doc-error-extends branch from 3d4d1ee to 5c9209b Aug 27, 2019

@trivikr trivikr merged commit 5c9209b into nodejs:master Aug 27, 2019

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details

@trivikr trivikr deleted the trivikr:doc-error-extends branch Aug 27, 2019

@trivikr

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2019

Landed in 5c9209b

BridgeAR added a commit that referenced this pull request Sep 3, 2019
doc,errors: add extends to derived classes
PR-URL: #29303
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR referenced this pull request Sep 3, 2019
BridgeAR added a commit that referenced this pull request Sep 4, 2019
doc,errors: add extends to derived classes
PR-URL: #29303
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc,errors: add extends to derived classes
PR-URL: nodejs#29303
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
doc,errors: add extends to derived classes
PR-URL: nodejs#29303
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.