Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: improve once() performance #29307

Closed
wants to merge 1 commit into from

Conversation

@mscdex
Copy link
Contributor

commented Aug 25, 2019

Results:

                                      confidence improvement accuracy (*)   (**)  (***)
 events/ee-once.js argc=0 n=20000000        ***     15.46 %       ±3.02% ±4.02% ±5.24%
 events/ee-once.js argc=1 n=20000000        ***     10.71 %       ±3.48% ±4.64% ±6.05%
 events/ee-once.js argc=4 n=20000000        ***     13.51 %       ±2.84% ±3.77% ±4.91%
 events/ee-once.js argc=5 n=20000000        ***     13.72 %       ±4.01% ±5.35% ±6.99%
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@nodejs-github-bot

This comment has been minimized.

@bnoordhuis
Copy link
Member

left a comment

Obvious optimization is obvious (in hindsight.) ^^

@lpinca
lpinca approved these changes Aug 25, 2019
@nodejs-github-bot

This comment has been minimized.

@ZYSzys
ZYSzys approved these changes Aug 27, 2019
ZYSzys added a commit that referenced this pull request Aug 27, 2019
events: improve once() performance
PR-URL: #29307
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@ZYSzys

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

Landed in 5ba3a2c.

@ZYSzys ZYSzys closed this Aug 27, 2019

BridgeAR added a commit that referenced this pull request Sep 3, 2019
events: improve once() performance
PR-URL: #29307
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@BridgeAR BridgeAR referenced this pull request Sep 3, 2019
BridgeAR added a commit that referenced this pull request Sep 4, 2019
events: improve once() performance
PR-URL: #29307
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
events: improve once() performance
PR-URL: nodejs#29307
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
events: improve once() performance
PR-URL: nodejs#29307
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.