Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update babel-eslint and eslint #29320

Merged
merged 2 commits into from Aug 28, 2019

Conversation

@cjihrig
Copy link
Contributor

commented Aug 26, 2019

This PR updates ESLint to version 6.2.2 from 6.1.0. This update includes version 6.2.1, which was a security release.

This PR also updates babel-eslint due to eslint/eslint#12117.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@Trott
Trott approved these changes Aug 26, 2019
Copy link
Member

left a comment

Rubber-stamp LGTM

@danbev
danbev approved these changes Aug 26, 2019
@ZYSzys
ZYSzys approved these changes Aug 26, 2019
Copy link
Member

left a comment

RSLGTM

@trivikr
Copy link
Member

left a comment

RSLGTM

@cjihrig

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

cjihrig added 2 commits Aug 26, 2019
tools: update babel-eslint to 10.0.3
PR-URL: #29320
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
tools: update ESLint to 6.2.2
Update ESLint to 6.2.2

PR-URL: #29320
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

@cjihrig cjihrig force-pushed the cjihrig:eslint branch from 924cd19 to 403dacf Aug 28, 2019

@cjihrig cjihrig merged commit 403dacf into nodejs:master Aug 28, 2019

1 of 2 checks passed

Travis CI - Pull Request Build Errored
Details
Travis CI - Branch Build Passed
Details

@cjihrig cjihrig deleted the cjihrig:eslint branch Aug 28, 2019

BridgeAR added a commit that referenced this pull request Sep 3, 2019
tools: update babel-eslint to 10.0.3
PR-URL: #29320
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
BridgeAR added a commit that referenced this pull request Sep 3, 2019
tools: update ESLint to 6.2.2
Update ESLint to 6.2.2

PR-URL: #29320
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@BridgeAR BridgeAR referenced this pull request Sep 3, 2019
BridgeAR added a commit that referenced this pull request Sep 4, 2019
tools: update babel-eslint to 10.0.3
PR-URL: #29320
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
BridgeAR added a commit that referenced this pull request Sep 4, 2019
tools: update ESLint to 6.2.2
Update ESLint to 6.2.2

PR-URL: #29320
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
tools: update babel-eslint to 10.0.3
PR-URL: nodejs#29320
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
tools: update ESLint to 6.2.2
Update ESLint to 6.2.2

PR-URL: nodejs#29320
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
tools: update babel-eslint to 10.0.3
PR-URL: nodejs#29320
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
tools: update ESLint to 6.2.2
Update ESLint to 6.2.2

PR-URL: nodejs#29320
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.