crypto: don't expose OpenSSL internals #29325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
ryzokuken
approved these changes
Aug 26, 2019
There was a problem hiding this comment.
LGTM, feel free to land after @tniessen or @sam-github approve. Thanks for this!
davidben
reviewed
Aug 26, 2019
codebytere
force-pushed
the
crypto-oaepHash-boringssl
branch
from
2ec84d4
to
5b722d6
Compare
jasnell
approved these changes
Aug 26, 2019
codebytere
changed the title
bnoordhuis
approved these changes
Aug 27, 2019
danbev
added
the
author ready
|
CI passed too! Landing this. |
ryzokuken
pushed a commit
that referenced
this pull request
Aug 29, 2019
PR-URL: #29325 Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
|
Landed in 17a697c 🎉 |
BridgeAR
pushed a commit
that referenced
this pull request
Sep 3, 2019
PR-URL: #29325 Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 4, 2019
PR-URL: #29325 Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 5, 2019
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 5, 2019
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 5, 2019
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 5, 2019
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 6, 2019
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 19, 2019
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 23, 2019
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 27, 2019
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 14, 2019
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#28335 extended RSA-OAEP support with
oaepHash, which works perfectly fine for OpenSSL but unfortunately is a bespoke internal for BoringSSL, and so fails to compile in Electron as BoringSSL does not exposeEVP_PKEY_OP_TYPE_CRYPTorEVP_PKEY_CTRL_RSA_OAEP_MD.OpenSSL has a macro
EVP_PKEY_CTX_set_rsa_oaep_mdthat accomplished the selfsame purpose as documented, and which this PR switches to in order to allow BoringSSL compilation.Passing a bad or null digest to this new macro returns an error like
ERR_OSSL_BAD_DECODEand as such the error i've added tonode_errorsallows for a thrown error that retains the previous context.cc @tniessen @ryzokuken
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes