Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test-benchmark-net #29359

Closed
wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

commented Aug 28, 2019

Fix test-benchmark-net to accommodate recent benchmark additions.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
test: fix test-benchmark-net
Fix test-benchmark-net to accommodate recent benchmark additions.

@Trott Trott added fast-track and removed test labels Aug 28, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Aug 28, 2019

Collaborators, 👍 here to fast-track. (node-daily-master will fail until this fix or similar lands.)

@Trott Trott added the author ready label Aug 28, 2019

@Trott

This comment has been minimized.

Copy link
Member Author

commented Aug 28, 2019

Landed in 167960f

@Trott Trott closed this Aug 28, 2019

Trott added a commit to Trott/io.js that referenced this pull request Aug 28, 2019
test: fix test-benchmark-net
Fix test-benchmark-net to accommodate recent benchmark additions.

PR-URL: nodejs#29359
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR added a commit that referenced this pull request Sep 3, 2019
test: fix test-benchmark-net
Fix test-benchmark-net to accommodate recent benchmark additions.

PR-URL: #29359
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BridgeAR BridgeAR referenced this pull request Sep 3, 2019
BridgeAR added a commit that referenced this pull request Sep 4, 2019
test: fix test-benchmark-net
Fix test-benchmark-net to accommodate recent benchmark additions.

PR-URL: #29359
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
test: fix test-benchmark-net
Fix test-benchmark-net to accommodate recent benchmark additions.

PR-URL: nodejs#29359
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
JeniaBR added a commit to JeniaBR/node that referenced this pull request Sep 11, 2019
test: fix test-benchmark-net
Fix test-benchmark-net to accommodate recent benchmark additions.

PR-URL: nodejs#29359
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.